Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added user json as createdBy field in getLicense #89

Merged
merged 2 commits into from
Feb 27, 2025
Merged

feat: added user json as createdBy field in getLicense #89

merged 2 commits into from
Feb 27, 2025

Conversation

bhowmik94
Copy link

@bhowmik94 bhowmik94 commented Oct 28, 2024 •
edited by GMishx
Loading

Changes

Submitter Checklist

  • Includes tests (if there is a feature changed/added)
  • Includes docs ( if changes are user facing)
  • I have tested my changes locally.

References

@bhowmik94 bhowmik94 force-pushed the feat/api/createdBy-in-license branch 3 times, most recently from e8700af to b80d684 Compare November 7, 2024 09:14
deo002
deo002 reviewed Jan 16, 2025
View reviewed changes
@deo002
Copy link
Collaborator

deo002 commented Jan 16, 2025

Load user on /licenses/{shortname} GET

@deo002
Copy link
Collaborator

deo002 commented Jan 16, 2025

Set createdBy field when a license is created while importing

@deo002
Copy link
Collaborator

deo002 commented Jan 16, 2025

Also, remove merge conflicts

@deo002 deo002 force-pushed the feat/api/createdBy-in-license branch from 34415c4 to 38e14e0 Compare February 19, 2025 06:36
@deo002 deo002 requested review from deo002 and GMishx February 19, 2025 06:42
GMishx
GMishx requested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good. However, I can pass a user object while creating a license and spoof a userid.

@deo002 deo002 force-pushed the feat/api/createdBy-in-license branch from 38e14e0 to 4516b85 Compare February 27, 2025 07:42
@deo002 deo002 force-pushed the feat/api/createdBy-in-license branch from 4516b85 to 38a7251 Compare February 27, 2025 07:56
GMishx
GMishx approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMishx GMishx merged commit 9bb36c7 into fossology:main Feb 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@deo002 deo002 Awaiting requested review from deo002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add user json field as createdBy in license GET api
3 participants
@bhowmik94 @deo002 @GMishx