Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(license_preview): Created an endpoint to fetch all license shortnames #72

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

deo002
Copy link
Collaborator

@deo002 deo002 commented Jun 11, 2024

Changes

  • Create an endpoint to fetch shortnames of all licenses. This data will be displayed as options in the multiselect input which adds licenses to a obligation.

Submitter Checklist

  • Includes tests (if there is a feature changed/added)
  • Includes docs ( if changes are user facing)
  • I have tested my changes locally.

References

@deo002 deo002 requested a review from GMishx June 11, 2024 09:17
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea, would it be feasible to develop an endpoint that returns fields on request?

I know something like this in gRPC: https://google.aip.dev/157
And also worked on a REST API: tektoncd/results#642

pkg/api/licenses.go Outdated Show resolved Hide resolved
pkg/api/licenses.go Outdated Show resolved Hide resolved
@deo002 deo002 force-pushed the license_preview branch from ff1dce5 to 61bd07f Compare June 11, 2024 09:43
@deo002
Copy link
Collaborator Author

deo002 commented Jun 11, 2024

Just an idea, would it be feasible to develop an endpoint that returns fields on request?

Yep, nice idea. If we get more UI screens with different fields of the same data being displayed, the endpoint sure will save a lot of code and effort.
But I guess this should suffice for now.
What do you think @GMishx ?

@GMishx
Copy link
Member

GMishx commented Jun 19, 2024

Just an idea, would it be feasible to develop an endpoint that returns fields on request?

Yep, nice idea. If we get more UI screens with different fields of the same data being displayed, the endpoint sure will save a lot of code and effort. But I guess this should suffice for now. What do you think @GMishx ?

I too agree we can add that functionality if we are moving towards GraphQL or gRPC. For now, this should be good enough.

pkg/api/licenses.go Outdated Show resolved Hide resolved
@deo002 deo002 force-pushed the license_preview branch from 61bd07f to bcab679 Compare June 21, 2024 10:16
@deo002 deo002 requested a review from GMishx June 21, 2024 10:18
@GMishx GMishx merged commit f6f5616 into fossology:main Jun 28, 2024
7 checks passed
@GMishx GMishx deleted the license_preview branch June 28, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants