Skip to content

Check downlodable link with get header #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dd-jy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check downlodable link with get header #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/fosslight_util/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,14 @@ def alarm_handler(signum, frame):

def is_downloadable(url):
try:
h = requests.head(url, allow_redirects=True)
header = h.headers
content_type = header.get('content-type')
if 'text/html' in content_type.lower():
return False
content_disposition = header.get('content-disposition')
if content_disposition and 'attachment' in content_disposition.lower():
with requests.get(url, stream=True, allow_redirects=True, timeout=10) as r:
if r.status_code >= 400:
return False
content_type = r.headers.get('content-type', '').lower()
if 'text/html' in content_type:
logger.warning(f"Content-Type is text/html, not a downloadable link: {url}")
return False
return True
return True
except Exception as e:
logger.warning(f"is_downloadable - failed: {e}")
return False
Expand Down
Loading