Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add string translation for si, ar, pl and ru #2663

Merged
merged 5 commits into from
Apr 6, 2025

Conversation

huitk
Copy link
Contributor

@huitk huitk commented Apr 2, 2025

Fixes #2659

Changes

  • Add translation for string.xml to Arabic, Sinhala, Polish, and Russian
  • The changes are on line 13, 271-273, 288-299, 321-322, 324-325, 335-338

Screenshots / Recordings

N/A

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Add translations for strings in Arabic, Sinhala, Polish, and Russian languages, expanding the app's localization support

New Features:

  • Added navigation documentation string for multiple languages

Enhancements:

  • Expanded string translations for sensor names, UI elements, and technical terms
  • Added translations for directional and color-related strings

Documentation:

  • Improved language support for Arabic, Sinhala, Polish, and Russian locales

Copy link

sourcery-ai bot commented Apr 2, 2025

Reviewer's Guide by Sourcery

This pull request adds string translations to Arabic, Sinhala, Polish, and Russian. It also introduces new string resources for sensor-related features, gesture recognition, environmental conditions, and UI elements. Additionally, a new navigation option for documentation has been added.

Updated class diagram for strings.xml

classDiagram
    class strings_xml {
        +String Toast_double_tap
        +String Toast_magnetic_not_present
        +String nav_device
        +String nav_instruments
        +String nav_settings
        +String nav_about_us
        +String nav_documentation
        +String nav_buy_pslab
        +String nav_report
        +String nav_help_feedback
        +String time_unit_la
        +String view
        +String hmc5883l
        +String mpu6050
        +String sht21
        +String tmp102
        +String bh1750
        +String mlx90614
        +String bmp180
        +String mpu925x
        +String vl53l0x
        +String ccs811
        +String apds9960
        +String raw_data
        +String configure
        +String plot
        +String CH1
        +String CH2
        +String CH3
        +String CH4
        +String SINE
        +String SQUARE
        +String SAWTOOTH
        +String TRIANGLE
        +String CUSTOM
        +String ADC1
        +String ADC2
        +String ADC3
        +String PCS
        +String CAP
        +String CURRENT
        +String VOLTAGE
        +String RESISTANCE
        +String PH
        +String LUX
        +String FREQUENCY
        +String DUTY_CYCLE
        +String IC_24LC32A
        +String IC_24LC64
        +String IC_24LC128
        +String IC_24LC256
        +String IC_24LC512
        +String IC_24FC32A
        +String IC_24FC64
        +String IC_24FC128
        +String IC_24FC256
        +String IC_24FC512
        +String IC_24AA32A
        +String IC_24AA64
        +String IC_24AA128
        +String IC_24AA256
        +String IC_24AA512
        +String IC_AT24C32
        +String IC_AT24C64
        +String IC_AT24C128
        +String IC_AT24C256
        +String IC_AT24C512
        +String IC_FM24C32
        +String IC_FM24C64
        +String IC_FM24C128
        +String IC_FM24C256
        +String IC_FM24C512
        +String IC_M24C32
        +String IC_M24C64
        +String IC_M24C128
        +String IC_M24C256
        +String IC_M24C512
        +String IC_BR24C32
        +String IC_BR24C64
        +String IC_BR24C128
        +String IC_BR24C256
        +String IC_BR24C512
        +String IC_BL24C32
        +String IC_BL24C64
        +String IC_BL24C128
        +String IC_BL24C256
        +String IC_BL24C512
        +String IC_CAT24C32
        +String IC_CAT24C64
        +String IC_CAT24C128
        +String IC_CAT24C256
        +String IC_CAT24C512
        +String IC_ST24C32
        +String IC_ST24C64
        +String IC_ST24C128
        +String IC_ST24C256
        +String IC_ST24C512
        +String IC_X24C32
        +String IC_X24C64
        +String IC_X24C128
        +String IC_X24C256
        +String IC_X24C512
        +String IC_Microchip_24LC32
        +String IC_Microchip_24LC64
        +String IC_Microchip_24LC128
        +String IC_Microchip_24LC256
        +String IC_Microchip_24LC512
        +String IC_Microchip_24FC32
        +String IC_Microchip_24FC64
        +String IC_Microchip_24FC128
        +String IC_Microchip_24FC256
        +String IC_Microchip_24FC512
        +String IC_Microchip_24AA32
        +String IC_Microchip_24AA64
        +String IC_Microchip_24AA128
        +String IC_Microchip_24AA256
        +String IC_Microchip_24AA512
        +String IC_Atmel_AT24C32
        +String IC_Atmel_AT24C64
        +String IC_Atmel_AT24C128
        +String IC_Atmel_AT24C256
        +String IC_Atmel_AT24C512
        +String IC_Fudan_FM24C32
        +String IC_Fudan_FM24C64
        +String IC_Fudan_FM24C128
        +String IC_Fudan_FM24C256
        +String IC_Fudan_FM24C512
        +String IC_ST_M24C32
        +String IC_ST_M24C64
        +String IC_ST_M24C128
        +String IC_ST_M24C256
        +String IC_ST_M24C512
        +String IC_Rohm_BR24C32
        +String IC_Rohm_BR24C64
        +String IC_Rohm_BR24C128
        +String IC_Rohm_BR24C256
        +String IC_Rohm_BR24C512
        +String IC_Catalyst_CAT24C32
        +String IC_Catalyst_CAT24C64
        +String IC_Catalyst_CAT24C128
        +String IC_Catalyst_CAT24C256
        +String IC_Catalyst_CAT24C512
        +String IC_Bright_BL24C32
        +String IC_Bright_BL24C64
        +String IC_Bright_BL24C128
        +String IC_Bright_BL24C256
        +String IC_Bright_BL24C512
        +String IC_Xicor_X24C32
        +String IC_Xicor_X24C64
        +String IC_Xicor_X24C128
        +String IC_Xicor_X24C256
        +String IC_Xicor_X24C512
        +String IC_ST_ST24C32
        +String IC_ST_ST24C64
        +String IC_ST_ST24C128
        +String IC_ST_ST24C256
        +String IC_ST_ST24C512
        +String device_connected_successfully
        +String device_not_found
        +String sensor_not_connected_tls
        +String time_unit_la
        +String view
        +String hmc5883l
        +String mpu6050
        +String sht21
        +String tmp102
        +String bh1750
        +String mlx90614
        +String bmp180
        +String mpu925x
        +String vl53l0x
        +String ccs811
        +String apds9960
        +String raw_data
        +String configure
        +String plot
        +String gx
        +String gy
        +String gz
        +String red
        +String green
        +String blue
        +String clear
        +String gesture
        +String eCO2
        +String eTVOC
        +String plot_lux
        +String plot_proximity
        +String proximity
        +String lux_unit
        +String light_lux
        +String temp
        +String luminosity
        +String humidity
        +String pressure
        +String altitude
        +String set_gain
        +String set_range
        +String set_resolution
        +String set_rate
        +String plot_accelerometer
        +String plot_gyroscope
        +String plot_eCO2
        +String plot_eTVOC
        +String rad
        +String ppm
        +String ppb
        +String angle
        +String time
        +String infinite_symbol
        +String ohm
        +String alt
        +String meter
        +String pascal
        +String up
        +String down
        +String left
        +String right
    }
Loading

File-Level Changes

Change Details Files
Added translations for various strings in Arabic, Sinhala, Polish, and Russian.
  • Translated strings in strings.xml for Arabic.
  • Translated strings in strings.xml for Sinhala.
  • Translated strings in strings.xml for Polish.
  • Translated strings in strings.xml for Russian.
app/src/main/res/values-ru/strings.xml
app/src/main/res/values-si/string.xml
app/src/main/res/values-pl/strings.xml
app/src/main/res/values-ar/strings.xml
Added new string resources for VL53L0X, CCS811, and APDS9960 sensors, gesture recognition, environmental conditions, and UI elements.
  • Added string resources for VL53L0X sensor.
  • Added string resources for CCS811 sensor.
  • Added string resources for APDS9960 sensor.
  • Added string resources for gesture recognition.
  • Added string resources for eCO2 and TVOC.
  • Added string resources for plot descriptions.
  • Added string resources for proximity and light lux.
  • Added string resources for colors.
  • Added string resources for directions.
app/src/main/res/values-ru/strings.xml
app/src/main/res/values-si/string.xml
app/src/main/res/values-pl/strings.xml
app/src/main/res/values-ar/strings.xml
app/src/main/res/values/strings.xml
Added a new navigation option for documentation.
  • Added a string resource for the 'Documentation' navigation item.
app/src/main/res/values-ru/strings.xml
app/src/main/res/values-si/string.xml
app/src/main/res/values-pl/strings.xml
app/src/main/res/values-ar/strings.xml

Assessment against linked issues

Issue Objective Addressed Explanation
#2659 Translate the strings in strings.xml into Arabic.
#2659 Translate the strings in strings.xml into Sinhala.
#2659 Translate the strings in strings.xml into Polish.
#2659 Translate the strings in strings.xml into Russian.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @huitk - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Thanks for adding these translations!
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Apr 2, 2025

@huitk huitk changed the title Added string translation to si, ar, pl and ru docs: add string translation for si, ar, pl and ru Apr 2, 2025
@marcnause marcnause self-requested a review April 2, 2025 21:09
@marcnause marcnause added the Status: Review Required Requested reviews from peers and maintainers label Apr 2, 2025
@marcnause marcnause force-pushed the strings-translation branch from 299762a to 9a9c825 Compare April 2, 2025 21:12
@marcnause marcnause merged commit e9a9a43 into fossasia:development Apr 6, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Required Requested reviews from peers and maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation needed for these string
2 participants