-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add string translation for si, ar, pl and ru #2663
Conversation
Reviewer's Guide by SourceryThis pull request adds string translations to Arabic, Sinhala, Polish, and Russian. It also introduces new string resources for sensor-related features, gesture recognition, environmental conditions, and UI elements. Additionally, a new navigation option for documentation has been added. Updated class diagram for strings.xmlclassDiagram
class strings_xml {
+String Toast_double_tap
+String Toast_magnetic_not_present
+String nav_device
+String nav_instruments
+String nav_settings
+String nav_about_us
+String nav_documentation
+String nav_buy_pslab
+String nav_report
+String nav_help_feedback
+String time_unit_la
+String view
+String hmc5883l
+String mpu6050
+String sht21
+String tmp102
+String bh1750
+String mlx90614
+String bmp180
+String mpu925x
+String vl53l0x
+String ccs811
+String apds9960
+String raw_data
+String configure
+String plot
+String CH1
+String CH2
+String CH3
+String CH4
+String SINE
+String SQUARE
+String SAWTOOTH
+String TRIANGLE
+String CUSTOM
+String ADC1
+String ADC2
+String ADC3
+String PCS
+String CAP
+String CURRENT
+String VOLTAGE
+String RESISTANCE
+String PH
+String LUX
+String FREQUENCY
+String DUTY_CYCLE
+String IC_24LC32A
+String IC_24LC64
+String IC_24LC128
+String IC_24LC256
+String IC_24LC512
+String IC_24FC32A
+String IC_24FC64
+String IC_24FC128
+String IC_24FC256
+String IC_24FC512
+String IC_24AA32A
+String IC_24AA64
+String IC_24AA128
+String IC_24AA256
+String IC_24AA512
+String IC_AT24C32
+String IC_AT24C64
+String IC_AT24C128
+String IC_AT24C256
+String IC_AT24C512
+String IC_FM24C32
+String IC_FM24C64
+String IC_FM24C128
+String IC_FM24C256
+String IC_FM24C512
+String IC_M24C32
+String IC_M24C64
+String IC_M24C128
+String IC_M24C256
+String IC_M24C512
+String IC_BR24C32
+String IC_BR24C64
+String IC_BR24C128
+String IC_BR24C256
+String IC_BR24C512
+String IC_BL24C32
+String IC_BL24C64
+String IC_BL24C128
+String IC_BL24C256
+String IC_BL24C512
+String IC_CAT24C32
+String IC_CAT24C64
+String IC_CAT24C128
+String IC_CAT24C256
+String IC_CAT24C512
+String IC_ST24C32
+String IC_ST24C64
+String IC_ST24C128
+String IC_ST24C256
+String IC_ST24C512
+String IC_X24C32
+String IC_X24C64
+String IC_X24C128
+String IC_X24C256
+String IC_X24C512
+String IC_Microchip_24LC32
+String IC_Microchip_24LC64
+String IC_Microchip_24LC128
+String IC_Microchip_24LC256
+String IC_Microchip_24LC512
+String IC_Microchip_24FC32
+String IC_Microchip_24FC64
+String IC_Microchip_24FC128
+String IC_Microchip_24FC256
+String IC_Microchip_24FC512
+String IC_Microchip_24AA32
+String IC_Microchip_24AA64
+String IC_Microchip_24AA128
+String IC_Microchip_24AA256
+String IC_Microchip_24AA512
+String IC_Atmel_AT24C32
+String IC_Atmel_AT24C64
+String IC_Atmel_AT24C128
+String IC_Atmel_AT24C256
+String IC_Atmel_AT24C512
+String IC_Fudan_FM24C32
+String IC_Fudan_FM24C64
+String IC_Fudan_FM24C128
+String IC_Fudan_FM24C256
+String IC_Fudan_FM24C512
+String IC_ST_M24C32
+String IC_ST_M24C64
+String IC_ST_M24C128
+String IC_ST_M24C256
+String IC_ST_M24C512
+String IC_Rohm_BR24C32
+String IC_Rohm_BR24C64
+String IC_Rohm_BR24C128
+String IC_Rohm_BR24C256
+String IC_Rohm_BR24C512
+String IC_Catalyst_CAT24C32
+String IC_Catalyst_CAT24C64
+String IC_Catalyst_CAT24C128
+String IC_Catalyst_CAT24C256
+String IC_Catalyst_CAT24C512
+String IC_Bright_BL24C32
+String IC_Bright_BL24C64
+String IC_Bright_BL24C128
+String IC_Bright_BL24C256
+String IC_Bright_BL24C512
+String IC_Xicor_X24C32
+String IC_Xicor_X24C64
+String IC_Xicor_X24C128
+String IC_Xicor_X24C256
+String IC_Xicor_X24C512
+String IC_ST_ST24C32
+String IC_ST_ST24C64
+String IC_ST_ST24C128
+String IC_ST_ST24C256
+String IC_ST_ST24C512
+String device_connected_successfully
+String device_not_found
+String sensor_not_connected_tls
+String time_unit_la
+String view
+String hmc5883l
+String mpu6050
+String sht21
+String tmp102
+String bh1750
+String mlx90614
+String bmp180
+String mpu925x
+String vl53l0x
+String ccs811
+String apds9960
+String raw_data
+String configure
+String plot
+String gx
+String gy
+String gz
+String red
+String green
+String blue
+String clear
+String gesture
+String eCO2
+String eTVOC
+String plot_lux
+String plot_proximity
+String proximity
+String lux_unit
+String light_lux
+String temp
+String luminosity
+String humidity
+String pressure
+String altitude
+String set_gain
+String set_range
+String set_resolution
+String set_rate
+String plot_accelerometer
+String plot_gyroscope
+String plot_eCO2
+String plot_eTVOC
+String rad
+String ppm
+String ppb
+String angle
+String time
+String infinite_symbol
+String ohm
+String alt
+String meter
+String pascal
+String up
+String down
+String left
+String right
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @huitk - I've reviewed your changes - here's some feedback:
Overall Comments:
- Thanks for adding these translations!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/14295115519/artifacts/2890541306 |
299762a
to
9a9c825
Compare
Fixes #2659
Changes
Screenshots / Recordings
N/A
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Summary by Sourcery
Add translations for strings in Arabic, Sinhala, Polish, and Russian languages, expanding the app's localization support
New Features:
Enhancements:
Documentation: