chore: Release v1.7.0 (#2734)

chore: Release v1.7.0

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,40 @@
+---
+name: Bug report
+about: Create a bug report to help us improve
+
+---
+
+**Describe the bug**
+<!-- A clear and concise description of what the bug is. -->
+
+**To Reproduce**
+<!--Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error -->
+
+**Expected behavior**
+<!-- A clear and concise description of what you expected to happen. -->
+
+**Logs**
+<!-- Please add logs in case of any crash or applicable error. -->
+
+**Screenshots**
+<!-- If applicable, add screenshots to help explain your problem. -->
+
+**Smartphone Info:**
+<!-- Please complete the following information -->
+|               | |
+|---------------|-|
+|Device         |<!-- [e.g. Moto G5 Plus] -->|
+|Android Version|<!-- [e.g. Oreo 8.1] -->    |
+
+**Additional context**
+<!-- Add any other context about the problem here. -->
+
+**Would you like to work on the issue?**
+<!-- Please let us know if you can work on it or the issue should be assigned to someone else. -->
+- [ ] Yes
+- [ ] No
+- Other: 

.github/ISSUE_TEMPLATE/chore.md

@@ -0,0 +1,14 @@
+---
+name: Chore
+about: Issues related to docs, workflow, dependency and others
+
+---
+
+**Describe the chore**
+<!-- A clear and concise description of what you want to do. -->
+
+**Would you like to work on the issue?**
+<!-- Please let us know if you can work on it or the issue should be assigned to someone else. -->
+- [ ] Yes
+- [ ] No
+- Other:

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest a feature for this project
+
+---
+
+**Describe the feature you'd like**
+<!-- A clear and concise description of what you want to happen. -->
+
+**Screenshots**
+<!-- Add screenshots to provide context or UI mockup. -->
+
+**Additional context**
+<!-- Add any other context about the problem here. -->
+
+**Would you like to work on the issue?**
+<!-- Please let us know if you can work on it or the issue should be assigned to someone else. -->
+- [ ] Yes
+- [ ] No
+- Other:

README.md

@@ -48,7 +48,7 @@ Do you have many different apps on your Android Phone for the purpose of clickin
 
 * Finally, after all this editing you can easily share the image to your favourite social media sites with our easy-to-use sharing feature.
 
-* Facebook, Twitter, NextCloud, OwnCloud, Imgur, Dropbox, Box, Flickr, Pinterest, Instagram, Whatsapp, and Tumblr - You name it and we have it covered.
+* Facebook, Messenger, Twitter, NextCloud, OwnCloud, Imgur, Dropbox, Box, Flickr, Pinterest, Instagram, Whatsapp, and Tumblr - You name it and we have it covered.
 
 ## How to Contribute
 This is an Open Source project and we would be happy to see contributors who report bugs and file feature requests by submitting pull requests as well.This project adheres to the [Contributor Covenant](https://github.com/fossasia/phimpme-android/blob/development/CONTRIBUTING.md). By participating, you are expected to uphold this code style. Please report issues here https://github.com/fossasia/phimpme-android/issues
@@ -109,19 +109,19 @@ Before you begin, you should have already downloaded the Android Studio SDK and
      - Copy all the files from *"OpenCV-android-sdk/sdk/native/libs"* to *"phimpme-android/app/src/main/jniLibs"* (create directory if it doesn't exist)
      - Now build your project. If your build fails then try deleting these build directories *"phimpme-android/app/.externalNativeBuild"* and *"phimpme-android/app/build"*, if they exist and run the build again.
 
-7. Once all build errors have been resolved, you should be all set to build the app and test it.
+7. If build error still persist, try replacing ndk with ndk version 16b from [ndk-archives](https://developer.android.com/ndk/downloads/older_releases) .  Once all build errors have been resolved, you should be all set to build the app and test it.
 
 8. To Build the app, go to *Build > Make Project* (or alternatively press the Make Project icon in the toolbar).
 
 9. If the app was built successfully, you can test it by running it on either a real device or an emulated one by going to *Run > Run 'app'* or pressing the Run icon in the toolbar.
 
 10. **To enable the sharing features to a different account, add API_KEY/ APP_ID associated with accounts**. Add the Keys in `constant.java` and `strings.xml`. Following are the links to developer pages of account. Go there to create apps and get keys.
-    * Facebook: https://developers.facebook.com
+    * Nextcloud: https://docs.nextcloud.com/server/stable/developer_manual/
     * Twitter: https://dev.twitter.com
     * Flickr: https://www.flickr.com/services/developer
     * Pinterest: https://developers.pinterest.com
-    * Tumblr: https://www.tumblr.com/developers
-    * Imgur: https://api.imgur.com
+    * Owncloud: https://doc.owncloud.org/server/10.0/developer_manual/
+    * Imgur: https://apidocs.imgur.com/
     * Box: https://developer.box.com
     * Dropbox: https://www.dropbox.com/developers
 
@@ -138,7 +138,9 @@ The project is maintained by
 <table border="0">
 <tr>
 <td width="240">
+     <p align="center">
      <img src="https://avatars2.githubusercontent.com/u/20367966?v=4&s=150" />
+     </p>
      <div align="center">
      Anant Prasad
 </div>
@@ -150,8 +152,10 @@ The project is maintained by
 </td>
 
 <td width="240">
+     <p align="center">
      <img src="https://avatars0.githubusercontent.com/u/9361754?v=4&s=150"/>
-        <div align="center">
+     </p>
+     <div align="center">
     Mohit Manuja
 </div>
 <p align="center">
@@ -162,7 +166,9 @@ The project is maintained by
 </td>
 
 <td width="240">
+     <p align="center">
      <img src="https://avatars1.githubusercontent.com/u/6936968?v=4&s=150" />
+     </p>
      <div align="center">
      Pawan Pal
 </div>
@@ -174,7 +180,9 @@ The project is maintained by
 </td>
 
 <td width="240">
-     <img src="https://avatars0.githubusercontent.com/u/17337006?v=4&s=150"/>
+     <p align="center">
+     <img src="https://avatars0.githubusercontent.com/u/17337006?v=4&s=150" />
+     </p>
      <div align="center">
     Subhankar Shah
 </div>
@@ -189,8 +197,10 @@ The project is maintained by
 
 <tr>
 <td width="240">
-     <img src="https://avatars2.githubusercontent.com/u/15368561?v=4&s=150"/>
-     <div align="center">
+    <p align="center">
+    <img src="https://avatars2.githubusercontent.com/u/15368561?v=4&s=150" />
+    </p>
+    <div align="center">
     Vinay Sajjanapu
 </div>
 <p align="center">
@@ -201,8 +211,10 @@ The project is maintained by
 </td>
 
 <td width="240">
-     <img src="https://avatars1.githubusercontent.com/u/20841578?s=150&u=ccf2c85bac58c92f69c4c69ce2c46dcee4564e23&v=4"/>
-     <div align="center">
+    <p align="center">
+    <img src="https://avatars1.githubusercontent.com/u/20841578?s=150&u=ccf2c85bac58c92f69c4c69ce2c46dcee4564e23&v=4" />
+    </p>
+    <div align="center">
     Saurav Vishal
 </div>
 

app/build.gradle

@@ -111,7 +111,7 @@ dependencies {
     compile 'com.google.android.exoplayer:exoplayer:r1.5.7'
 
     //utils
-    compile 'com.github.deano2390:MaterialShowcaseView:1.1.0'
+    compile 'com.github.deano2390:MaterialShowcaseView:1.2.0@aar'
     compile "com.jakewharton:butterknife:$rootProject.butterknifeVersion"
     annotationProcessor "com.jakewharton:butterknife-compiler:$rootProject.butterknifeVersion"
     compile 'com.github.bumptech.glide:glide:3.7.0'

app/src/main/AndroidManifest.xml

@@ -1,15 +1,35 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
-          package="org.fossasia.phimpme"
-          android:versionCode="8"
-          android:versionName="1.6.0">
+    package="org.fossasia.phimpme"
+    android:versionCode="9"
+    android:versionName="1.7.0">
 
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
+
     <uses-permission android:name="android.permission.READ_SMS"
         tools:node="remove"/>
     <uses-permission android:name="android.permission.RECEIVE_SMS"
         tools:node="remove"/>
+    <uses-permission android:name="android.permission.SEND_SMS"
+        tools:node="remove"/>
+    <uses-permission android:name="android.permission.WRITE_SMS"
+        tools:node="remove"/>
+    <uses-permission android:name="android.permission.CALL_PHONE"
+        tools:node="remove"/>
+    <uses-permission android:name="android.permission.WRITE_CALL_LOG"
+        tools:node="remove"/>
+    <uses-permission android:name="android.permission.READ_CALL_LOG"
+        tools:node="remove"/>
+    <uses-permission android:name="android.permission.PROCESS_OUTGOING_CALLS"
+        tools:node="remove"/>
+    <uses-permission android:name="android.permission.MANAGE_OWN_CALLS"
+        tools:node="remove"/>
+    <uses-permission android:name="android.permission.ANSWER_PHONE_CALLS"
+        tools:node="remove"/>
+    <uses-permission android:name="android.permission.READ_PHONE_NUMBERS"
+        tools:node="remove"/>
+
     <uses-permission android:name="android.permission.CAMERA" />
     <uses-permission android:name="android.permission.RECORD_AUDIO" />
     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
@@ -45,8 +65,8 @@
 
         <activity
             android:name=".opencamera.Camera.CameraActivity"
-            android:screenOrientation="portrait"
             android:parentActivityName=".gallery.activities.LFMainActivity"
+            android:screenOrientation="portrait"
             android:theme="@style/Theme.AppCompat.NoActionBar">
             <intent-filter>
                 <action android:name="android.media.action.IMAGE_CAPTURE_SECURE" />
@@ -193,6 +213,7 @@
             android:name=".gallery.activities.SingleMediaActivity"
             android:configChanges="orientation|screenSize|uiMode|touchscreen|screenLayout"
             android:label="@string/app_name"
+            android:windowSoftInputMode="adjustPan"
             android:parentActivityName=".gallery.activities.LFMainActivity"
             android:theme="@style/Theme.AppCompat.NoActionBar">
             <intent-filter>
@@ -210,7 +231,7 @@
 
                 <category android:name="android.intent.category.DEFAULT" />
             </intent-filter>
-            <intent-filter>
+            <intent-filter tools:ignore="AppLinkUrlError">
                 <action android:name="android.intent.action.VIEW" />
 
                 <category android:name="android.intent.category.DEFAULT" />
@@ -236,6 +257,7 @@
         <activity
             android:name=".gallery.activities.SettingsActivity"
             android:configChanges="orientation|screenSize"
+            android:windowSoftInputMode="adjustNothing"
             android:label="@string/settings"
             android:theme="@style/Theme.AppCompat.NoActionBar">
             <intent-filter>
@@ -284,9 +306,10 @@
         <activity
             android:name=".editor.EditImageActivity"
             android:theme="@style/AppTheme.NoActionBar"
+
             android:windowSoftInputMode="adjustPan"
-            android:configChanges="orientation|screenSize"
             />
+
         <activity
             android:name="com.yalantis.ucrop.UCropActivity"
             android:screenOrientation="portrait"
@@ -371,8 +394,7 @@
             android:value="78c6ec5c18fcd10ffbfd28ae038f3311f2763889" />
 
         <activity android:name=".editor.CompressImageActivity"></activity>
-        <activity android:name=".trashbin.TrashBinActivity">
-        </activity>
+        <activity android:name=".trashbin.TrashBinActivity"></activity>
     </application>
 
 </manifest>

app/src/main/java/org/fossasia/phimpme/MyApplication.java

@@ -29,8 +29,6 @@ public class MyApplication extends Application {
 
     private HandlingAlbums albums = null;
     public static Context applicationContext;
-    public ImageLoader imageLoader;
-    private Boolean isPublished = false; // Set this to true at the time of release
     private RefWatcher refWatcher;
     public Album getAlbum() {
         return albums.dispAlbums.size() > 0 ? albums.getCurrentAlbum() : Album.getEmptyAlbum();

app/src/main/java/org/fossasia/phimpme/accounts/AccountActivity.java

@@ -3,8 +3,6 @@
 import android.content.Context;
 import android.content.DialogInterface;
 import android.content.Intent;
-import android.net.ConnectivityManager;
-import android.net.NetworkInfo;
 import android.os.Bundle;
 import android.support.design.widget.BottomNavigationView;
 import android.support.design.widget.CoordinatorLayout;
@@ -84,7 +82,6 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
     private static final int NEXTCLOUD_REQUEST_CODE = 3;
     private static final int OWNCLOUD_REQUEST_CODE = 9;
     private static final int RESULT_OK = 1;
-    private static final int RC_SIGN_IN = 9001;
     public static final String BROWSABLE = "android.intent.category.BROWSABLE";
     public final static String CLOUDRAIL_APP_KEY = Constants.CLOUDRAIL_LICENSE_KEY;//CloudRail_App-Key
     @BindView(R.id.accounts_parent)
@@ -109,7 +106,6 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
     private CloudRailServices cloudRailServices;
     private PDKClient pdkClient;
    // private GoogleApiClient mGoogleApiClient;
-    private DropboxAPI<AndroidAuthSession> mDBApi;
     private BoxSession sessionBox;
 
     @Override
@@ -216,11 +212,7 @@ public int getNavigationMenuItemId() {
 
     @Override
     public void onItemClick(final View childView, final int position) {
-        ConnectivityManager cm=(ConnectivityManager)context.getSystemService(Context.CONNECTIVITY_SERVICE);
-        NetworkInfo ni = cm.getActiveNetworkInfo();
-        if (ni == null) {
-           Snackbar.make(findViewById(android.R.id.content),getString(R.string.internet_is_off),Snackbar.LENGTH_SHORT).show();
-        }
+        if (!checkNetwork(this,parentLayout)) return;
         final SwitchCompat signInSignOut = childView.findViewById(R.id.sign_in_sign_out_switch);
         final String name = AccountDatabase.AccountName.values()[position].toString();
 
@@ -287,9 +279,6 @@ public void onItemClick(final View childView, final int position) {
                 /*case ONEDRIVE:
                     signInOneDrive();
                     break;*/
-
-                default:
-                    SnackBarHandler.show(coordinatorLayout, R.string.feature_not_present);
             }
         } else {
             AlertDialog alertDialog = new AlertDialog.Builder(this)
@@ -468,7 +457,7 @@ public void callBack(int status, Object data) {
     }
 
     private void signInPinterest() {
-        ArrayList<String> scopes = new ArrayList<String>();
+        ArrayList<String> scopes = new ArrayList<>();
         scopes.add(PDKClient.PDKCLIENT_PERMISSION_READ_PUBLIC);
         scopes.add(PDKClient.PDKCLIENT_PERMISSION_WRITE_PUBLIC);
         scopes.add(PDKClient.PDKCLIENT_PERMISSION_READ_RELATIONSHIPS);

app/src/main/java/org/fossasia/phimpme/accounts/AccountPresenter.java

@@ -56,6 +56,6 @@ public boolean checkAlreadyExist(AccountDatabase.AccountName s) {
         RealmResults<AccountDatabase> result1 = query.findAll();
 
         // Here checking if count of that values is greater than zero
-        return (result1.size() > 0) ? true : false;
+        return result1.size() > 0;
     }
 }

app/src/main/java/org/fossasia/phimpme/base/BaseActivity.java

@@ -61,7 +61,7 @@ protected void onCreate(Bundle savedInstanceState) {
          nav_cam = findViewById(R.id.navigation_camera);
          nav_acc = findViewById(R.id.navigation_accounts);
 
-        int checkStoragePermission = ContextCompat.checkSelfPermission(this, android.Manifest.permission.WRITE_EXTERNAL_STORAGE);
+        int checkStoragePermission = ContextCompat.checkSelfPermission(this, android.Manifest.permission.READ_EXTERNAL_STORAGE);
         if(checkStoragePermission  == PackageManager.PERMISSION_GRANTED)
             presentShowcaseSequence(); // one second delay