Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coala markdown linting #824

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Added coala markdown linting #824

merged 1 commit into from
Jan 4, 2017

Conversation

idealadarsh
Copy link
Member

@idealadarsh idealadarsh commented Jan 4, 2017

Thank you for your pull request! Please read and understand everything below

Please acknowledge that you have read and understood each of the following before submitting your pull request.

Do not delete any text other than where you are instructed.

Maintainers: If any of these are left unchecked, do not merge.

Students: If one of them is not applicable to you -- Please check it anyways. DO NOT REMOVE ANYTHING!

You may check them after opening your pull request.

You may do so by changing each [ ] to [x] Please take note of the whitespace as it matters.

  • Read and understood (see CONTRIBUTING.md)
  • Included a live link or preview screenshot
  • Images are 240 x 240 [w x h]
  • Resolved merge conflicts
  • Included a description of my change below

Things done in this Pull Request

@checkbot
Copy link

checkbot commented Jan 4, 2017

1 Warning
⚠️ Please mark all the checkboxes.
1 Message
📖 Hi @adarsh-ideal thank you for your submission at Fossasia’s GCI 2016 website. Please correct any issues above, if any.

Generated by 🚫 danger

@jigyasa-grover jigyasa-grover merged commit 1af3bd9 into fossasia:gh-pages Jan 4, 2017
@jayvdb
Copy link
Member

jayvdb commented Jan 4, 2017

Well that was badly done.
It was auto-patched 39c4abcf4a66 , and tools make mistakes like we can see on https://github.com/fossasia/gci16.fossasia.org/blob/gh-pages/CONTRIBUTING.md . This is why humans are still useful.

@robbyoconnor
Copy link
Contributor

Should we remove the auto-patcher @jayvdb ?

@jayvdb jayvdb mentioned this pull request Jan 5, 2017
@jayvdb
Copy link
Member

jayvdb commented Jan 5, 2017

@robbyoconnor , I see you had to fix it ;-( I tip my hat to your dedication to keeping this repo afloat for the GCI program.

@robbyoconnor
Copy link
Contributor

@jayvdb Perk of being unemployed -- I'm bored soo...

@robbyoconnor
Copy link
Contributor

Will continue discussion in #828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants