-
Notifications
You must be signed in to change notification settings - Fork 172
Add validation to prevent negative values in gift card settings #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 1 commit
1c5b58f
7604951
90435e2
2dfcc33
fc2e11c
b41e420
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2422,6 +2422,7 @@ def primary_font_kwargs(): | |
| 'The system generates by default {}-character long gift card codes. However, if a different length ' | ||
| 'is required, it can be set here.'.format(settings.ENTROPY['giftcard_secret']) | ||
| ), | ||
| min_value=1, | ||
| ), | ||
| }, | ||
| 'giftcard_expiry_years': { | ||
|
|
@@ -2435,6 +2436,7 @@ def primary_font_kwargs(): | |
| 'If you set a number here, gift cards will by default expire at the end of the year after this ' | ||
| 'many years. If you keep it empty, gift cards do not have an explicit expiry date.' | ||
| ), | ||
| min_value=0, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue (bug_risk): Clarify semantics of With
jevinjojo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ), | ||
| }, | ||
| 'privacy_policy': { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.