Added Proxy Configuration #544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.proxyHost = '', | ||
| this.proxyPort = '', | ||
| this.proxyUsername, | ||
| this.proxyPassword, |
There was a problem hiding this comment.
Instead of arguments, proxy fields should be a separate model.
| @@ -299,6 +299,11 @@ class CollectionStateNotifier | |||
| substitutedHttpRequestModel, | |||
| defaultUriScheme: defaultUriScheme, | |||
| noSSL: noSSL, | |||
| isProxyEnabled: ref.read(settingsProvider).isProxyEnabled, | |||
There was a problem hiding this comment.
Pass a single object for proxy settings or null.
ref.read(settingsProvider) is being done multiple times.
| @@ -0,0 +1,54 @@ | |||
| import 'package:flutter_riverpod/flutter_riverpod.dart'; | |||
| import '../models/proxy_config.dart'; | |||
There was a problem hiding this comment.
Where is proxy_config.dart code?
| import 'package:flutter_riverpod/flutter_riverpod.dart'; | ||
| import '../models/proxy_config.dart'; | ||
|
|
||
| final proxyConfigProvider = StateNotifierProvider<ProxyNotifier, ProxyConfig>((ref) { |
There was a problem hiding this comment.
What is the need of proxyConfigProvider?
| historyRetentionPeriod: historyRetentionPeriod, | ||
| workspaceFolderPath: workspaceFolderPath, | ||
| isSSLDisabled: isSSLDisabled, | ||
| state = SettingsModel( |
There was a problem hiding this comment.
Why have you removed copyWith?
| @@ -50,6 +51,75 @@ class SettingsPage extends ConsumerWidget { | |||
| ref.read(settingsProvider.notifier).update(isDark: value); | |||
| }, | |||
| ), | |||
| // Proxy Settings Section | |||
There was a problem hiding this comment.
Proxy settings should have its own modal dialog and model.
| @@ -11,6 +11,36 @@ http.Client createHttpClientWithNoSSL() { | |||
| return IOClient(ioClient); | |||
| } | |||
|
|
|||
| http.Client createHttpClientWithProxy( | |||
There was a problem hiding this comment.
Not clean code. A single custom client creation should be there for both ssl & proxy.
|
Apart from the above comments, testing is also missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pull request implements a feature that allows users to configure and use a proxy for their HTTP requests within the API Dash application. The feature includes a user interface for inputting proxy settings, storing these settings, and applying them to HTTP requests made using the http package in Flutter.
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
I have tested the proxy feature by running a squid proxy server in Python. Above I have attached the image proving that the proxy is working perfectly fine.
OS on which you have developed and tested the feature?