-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specialfunctions: generalize gamma
precision
#969
base: master
Are you sure you want to change the base?
Conversation
The CI builds have an issue in complex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @perazz . I like this solution. Smart approach IMO.
fpm build fails without
|
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Yes @osada-yum: I did not notice I have now generalized them too. |
Thank you @perazz. build log in
|
Thank you @perazz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @perazz
Fix #964.
gamma functions always require quad-precision even when not
WITH_QP
.Propose to: instead of hard-coded, the
KIND
s are taken from the lists of available ones.Because they're sorted with increasing accuracy, generate all accuracies except the last one
i+1
-th accuracy is used.xdp
is available, it is not enough to guarantee accuracy fordp
evaluation:qp
is always needed if present).This is a more generalized version than #967.
cc: @jvdp1 @jalvesz @loiseaujc @osada-yum