[LDAP] Add custom cbt_value #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anadrianmanrique
added
the
in review
|
@zblurx thanks for the PR. I think it would be nice to have an example to test signing/channel binding, not only because it would be helpful as an info gathering tool, but also to validate these changes as well. |
anadrianmanrique
added
the
waiting for response
anadrianmanrique
added
medium
|
@zblurx any update :) ? |
|
We are waiting changes adding an example that leverages these changes, as it was mentioned above |
|
Hey @anadrianmanrique @mpgn sorry for the delay, here is the example script. 
|
|
AH I'm gonna do the same for MSSQL then! |
- make channel_bidinng_value variable public
|
ok, I pushed changes related to code review in order to have this merged ASAP as we are closing 0.13 release. |
anadrianmanrique
removed
the
waiting for response
anadrianmanrique
approved these changes
Oct 2, 2025
examples/CheckLDAPStatus.py
Outdated
| # Login failed (wrong credentials). test if we get an error with an existing, but wrong CBT -> When supported | ||
| elif str(e).find("data 52e") >= 0: | ||
| ldap_connection = LDAPConnection(url=ldap_url) | ||
| new_cbv = bytearray(ldap_connection._LDAPConnection__channel_binding_value) |
There was a problem hiding this comment.
either define channel_biding_value as a public member in LDAPConnection or implement getter/setter methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys ! This simple PR allows for channel binding customization. This helps us a lot on NetExec to check for channel binding status. If you want, I can add a custom example script in Impacket to do LDAP Signing / Channel binding check. Let me know !