Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO 8178: correctly add "validator" param to interpolated error object #75

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Apr 8, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8178

Description

This PR did not correctly solve the issue of a missing "validator" param and didn't include tests. I've corrected the error by adding a ruleName prop that conforms to the 4.x renderer error keys and adding tests.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Automated tests added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

trueaniki
trueaniki approved these changes Apr 9, 2024
@AlexeyNikipelau AlexeyNikipelau merged commit 2333a6c into master Apr 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants