FIO-8037: fixed an issue where number component can be sent text thro… #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyNikipelau
requested changes
Apr 17, 2024
|
|
||
| // These are the validations that require a database connection. | ||
| export const databaseRules: ValidationRuleInfo[] = [ | ||
| validateUniqueInfo, | ||
| validateCaptchaInfo | ||
| validateCaptchaInfo, | ||
| validateNumberInfo |
There was a problem hiding this comment.
validateNumberInfo should not be in databaseRules. databaseRules contain only rules, that interact with database and therefore should not be performed in vm. validateNumberInfo should be placed in clientRules
| export const validateNumberSync: RuleFnSync = (context: ValidationContext) => { | ||
| const error = new FieldError('number', context); | ||
| const { value } = context; | ||
| if (!shouldValidate(context)) { |
There was a problem hiding this comment.
Please, remove this shouldValidate call, as it's already done in validation processor validationRules function.
AlexeyNikipelau
requested changes
Apr 17, 2024
AlexeyNikipelau
approved these changes
Apr 19, 2024
lane-formio
pushed a commit
that referenced
this pull request
May 21, 2024
…ent-text-through-API FIO-8037: fixed an issue where number component can be sent text thro…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ugh API
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8037
Description
Added validation to throw an error in case if a text value attempts to be submitted for number component.
Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Tested locally, added test for valid and invalid number value.
Checklist: