Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9189: fixed an issue where data is lost after submission for the conditionally visible field when the condition is based on select resource #174

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Oct 17, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9189

Description

What changed?

  • added a special check for the select resource with object type in isEqualTo operator
  • changed isNotEqualTo operator to use comparison logic from isEqualTo operator
  • moved some method from formiojs to core

Dependencies

Use this section to list any dependent changes/PRs in other Form.io modules

How has this PR been tested?

tests + manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…conditionally visible field when the condition is based on relect resource
@TanyaGashtold TanyaGashtold marked this pull request as draft October 17, 2024 10:46
@TanyaGashtold TanyaGashtold marked this pull request as ready for review October 17, 2024 13:12
@brendanbond brendanbond merged commit bef8aa0 into master Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants