Skip to content

Commit

Permalink
Fio-8316 invalid data submitted in nested form (#94)
Browse files Browse the repository at this point in the history
* skipping dataObject model types when filtering

* only skipping dataObject model types

* integrated istanbul code coverage testing with current thresholds

* removed console statements

* using functional version of lodash set so original submit object doesn't get mutated during filter post process

* verified dataGrid submissions are valid

---------

Co-authored-by: John Teague <[email protected]>
  • Loading branch information
2 people authored and lane-formio committed Jul 1, 2024
1 parent 6b0cb6b commit b42949c
Show file tree
Hide file tree
Showing 8 changed files with 3,153 additions and 2,885 deletions.
Binary file removed .DS_Store
Binary file not shown.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
.DS_Store
.vscode
node_modules
docs
lib
dist
.dccache
# ignore nyc output
.nyc_output
coverage
23 changes: 21 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"./dist/formio.core.min.js": "./dist/formio.core.min.js"
},
"scripts": {
"test": "TEST=1 mocha -r ts-node/register -r tsconfig-paths/register -r mock-local-storage -r jsdom-global/register -b -t 0 'src/**/__tests__/*.test.ts'",
"test": "TEST=1 nyc --reporter=lcov --reporter=text --reporter=text-summary mocha -r ts-node/register -r tsconfig-paths/register -r mock-local-storage -r jsdom-global/register -t 0 'src/**/__tests__/*.test.ts'",
"lib": "tsc --project tsconfig.json && tsc-alias -p tsconfig.json",
"replace": "node -r tsconfig-paths/register -r ts-node/register ./lib/base/array/ArrayComponent.js",
"test:debug": "mocha -r ts-node/register -r tsconfig-paths/register -r mock-local-storage -r jsdom-global/register --debug-brk --inspect '**/*.spec.ts'",
Expand Down Expand Up @@ -72,6 +72,7 @@
"mocha": "^10.0.0",
"mocha-jsdom": "^2.0.0",
"mock-local-storage": "^1.1.20",
"nyc": "^15.1.0",
"power-assert": "^1.6.1",
"sinon": "^17.0.1",
"ts-loader": "^9.5.0",
Expand All @@ -97,5 +98,23 @@
"json-logic-js": "^2.0.2",
"lodash": "^4.17.21",
"moment": "^2.29.4"
},
"nyc": {
"check-coverage": true,
"statements": 62,
"branches": 52,
"functions": 57,
"lines": 60,
"include": [
"src/**/*.ts",
"src/**/*.js"
],
"exclude": [
"src/**/*.test.ts",
"src/**/__tests__/",
"src/experimental/**/*.ts",
"src/types/**/*.ts"
],
"all": true
}
}
}
Loading

0 comments on commit b42949c

Please sign in to comment.