Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade #2

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Upgrade #2

merged 9 commits into from
Dec 4, 2024

Conversation

AlemTuzlak
Copy link
Contributor

Fixes #

Description

Made live client loaders happen

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

Copy link

github-actions bot commented Dec 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.18% 2 / 1059
🔵 Statements 0.18% 2 / 1059
🔵 Functions 11.11% 4 / 36
🔵 Branches 11.11% 4 / 36
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/root.tsx 0% 0% 0% 0% 1-133
app/realtime/player.ts 0% 0% 0% 0% 1-38
app/realtime/room.ts 0% 0% 0% 0% 1-20
app/routes/rooms.$roomId.tsx 0% 0% 0% 0% 1-222
Generated in workflow #10 for commit c2e29d8 by the Vitest Coverage Report Action

@AlemTuzlak AlemTuzlak enabled auto-merge (squash) December 4, 2024 17:17
@AlemTuzlak AlemTuzlak merged commit 5df677c into main Dec 4, 2024
4 checks passed
@AlemTuzlak AlemTuzlak deleted the realtime-upgrades branch December 4, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants