Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy #1

Merged
merged 8 commits into from
Dec 4, 2024
Merged

deploy #1

merged 8 commits into from
Dec 4, 2024

Conversation

thomasfr
Copy link
Contributor

@thomasfr thomasfr commented Dec 4, 2024

  • Added generate-env script which loads and replaces secrets based on APP_DEPLOYMENT_ENV from 1Password
  • Added min(1) cause an empty env var / empty string would not fail, catches some issues during deployment already
  • Added some defaults for local development

@thomasfr thomasfr requested a review from AlemTuzlak December 4, 2024 11:26
@thomasfr thomasfr marked this pull request as draft December 4, 2024 11:26
Copy link

github-actions bot commented Dec 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.18% 2 / 1053
🔵 Statements 0.18% 2 / 1053
🔵 Functions 11.42% 4 / 35
🔵 Branches 11.42% 4 / 35
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/env.server.ts 0% 0% 0% 0% 1-53
Generated in workflow #12 for commit 1259f71 by the Vitest Coverage Report Action

@thomasfr thomasfr changed the title added env var generation and some sane defaults deploy Dec 4, 2024
@thomasfr thomasfr marked this pull request as ready for review December 4, 2024 14:52
@thomasfr thomasfr merged commit a303a3f into main Dec 4, 2024
4 checks passed
@thomasfr thomasfr deleted the make-deploy-work branch December 4, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants