fix useActionData re-render issue, refactored mergeErrors & standardize errors to react-hook-form #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This should go in after: #33
or merge this and skip the other.
**Test Case: **
remix will send back errors on every re-render by default which means in order for react hook form to work as intended you will have to call your api on every state change. By adding the "shouldResetActionData" prop we allow user to pick to use react-hook-form behavior or remix form behavior.
standardize the errors returned by mergeErrors to match to react-hook-form error, this includes a type: "backend" to allow devs to know where the error came from.
Fixes # (issue)
Fixes issue #1 above, the useActionData issue were backend error are overriding resolved errors from the frontend, persisting the backend error after they are resolved or cleared with clearErrors().
If this is a new feature please add a description of what was added and why below:
see above
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: