New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated abortDelay property with RR7 streamTimeout #22

Closed

bravo-kernel wants to merge 1 commit into forge-42:main from bravo-kernel:deprecated-abortDelay

bravo-kernel commented Dec 24, 2024 •

edited

Loading

Team forgot to remove deprecated property abortDelay as can be seen in this changelog and confirmed in this discussion .

This patch replaces it with RR7 streamTimeout. Comments in proposed code change are taken from this page as well.

As mentioned in the ticket this "probably" fixes unnoticed issues with the streaming.

If you are still passing abortDelay in RR v7 then it's highly likely you have a functional bug in your app because your streams are not going to timeout properly


          Replace deprecated abortDelay with streamTimeout

2a7c25f

AlemTuzlak approved these changes

View reviewed changes

Contributor

AlemTuzlak commented Jan 5, 2025

@bravo-kernel thank you so much for this, I completely missed it, closing in favor of #23 due to failing checks!

AlemTuzlak closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet