refactor: work on minimizing grounding prompt #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-17432376@ refactored a bit of code into utils worked on reducing grounding prompt size.
daphne-sfdc
reviewed
Jan 3, 2025
Co-authored-by: Daphne Yang <[email protected]>
daphne-sfdc
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Thank you for changing sendApexPromptToLLM.ts to use the cleanupYaml() helper function.
I realized that the same change can be applied to this file sendRawPromptToLLM.ts. Lines 96-107 can be replaced with a call to cleanupYaml(). 🙂
daphne-sfdc
reviewed
Jan 6, 2025
| @@ -110,25 +110,13 @@ const buildPromptAndCallLLM = async (systemPrompt: string, userPrompt: string, c | |||
| } | |||
|
|
|||
| input += | |||
| `\n\`\`\`\n${endOfPromptTag}\n${assistantTag}`; | |||
| `\n\`\`\`\n${endOfPromptTag}\n${assistantTag}\n`; | |||
There was a problem hiding this comment.
Wow, a newline makes a big difference here at the end of the prompt! Now that the newline is added, I am able to generate OpenAPI v3 specifications from Apex classes without getting any errors.
daphne-sfdc
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thank you for this great system prompt consolidation and code refactoring @peternhale! Now we have gotten back some additional tokens for the context. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-17432376@
refactored a bit of code into utils
worked on reducing grounding prompt size.