Skip to content

Fix status bar icon color.#2703

Merged
brandonpage merged 1 commit intoforcedotcom:devfrom
brandonpage:status_bar_icon_color
Apr 14, 2025
Merged

Fix status bar icon color.#2703
brandonpage merged 1 commit intoforcedotcom:devfrom
brandonpage:status_bar_icon_color

Conversation

@brandonpage
Copy link
Copy Markdown
Contributor

@brandonpage brandonpage commented Apr 12, 2025

By default the color of the icons in the status bar is determined by the OS based, on if the user has set it to light or dark theme. This causes a readability problem if the OS/App theme and the dynamic login color differ. For example, if the user is in light theme the OS expects a light background but we display a dark status bar to match the webview this happens:
Screenshot 2025-04-11 at 4 09 01 PM

In this PR I am using our dynamicBackgroundTheme to set the window's isAppearanceLightStatusBars, which results in the status bar always being readable:
dynamic_status_bar_icons_long

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.66%. Comparing base (9fe843c) to head (c01f669).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/com/salesforce/androidsdk/ui/LoginActivity.kt 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #2703      +/-   ##
============================================
- Coverage     56.67%   56.66%   -0.01%     
  Complexity     2494     2494              
============================================
  Files           210      210              
  Lines         16992    16994       +2     
  Branches       2363     2364       +1     
============================================
  Hits           9630     9630              
- Misses         6315     6316       +1     
- Partials       1047     1048       +1     
Components Coverage Δ
Analytics 47.92% <ø> (ø)
SalesforceSDK 43.10% <0.00%> (-0.01%) ⬇️
Hybrid 58.05% <ø> (ø)
SmartStore 78.20% <ø> (ø)
MobileSync 82.02% <ø> (ø)
React 52.36% <ø> (ø)
Files with missing lines Coverage Δ
.../src/com/salesforce/androidsdk/ui/LoginActivity.kt 14.83% <0.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandonpage brandonpage merged commit dbe9c40 into forcedotcom:dev Apr 14, 2025
6 checks passed
wmathurin pushed a commit to wmathurin/SalesforceMobileSDK-Android that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants