Fix status bar icon color.#2703
Merged
brandonpage merged 1 commit intoforcedotcom:devfrom Apr 14, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #2703 +/- ##
============================================
- Coverage 56.67% 56.66% -0.01%
Complexity 2494 2494
============================================
Files 210 210
Lines 16992 16994 +2
Branches 2363 2364 +1
============================================
Hits 9630 9630
- Misses 6315 6316 +1
- Partials 1047 1048 +1
🚀 New features to boost your workflow:
|
wmathurin
approved these changes
Apr 12, 2025
wmathurin
pushed a commit
to wmathurin/SalesforceMobileSDK-Android
that referenced
this pull request
May 5, 2025
…color Fix status bar icon color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the color of the icons in the status bar is determined by the OS based, on if the user has set it to light or dark theme. This causes a readability problem if the OS/App theme and the dynamic login color differ. For example, if the user is in light theme the OS expects a light background but we display a dark status bar to match the webview this happens:

In this PR I am using our

dynamicBackgroundThemeto set the window'sisAppearanceLightStatusBars, which results in the status bar always being readable: