-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Laravel 5.8 #50
base: master
Are you sure you want to change the base?
Conversation
I will need to check this since I want to keep backward compatibility. I doubt it's not possible (even with the PHP minimum version). |
Php 7.1 is the minimal version for Laravel 5.8 |
Yes, but I have several project where it's the same and we just have to configure travis properly. The rest should work and stay the same |
i have try on a old project who I upgrade on laravel 5.8 but i obtain an error. Class 'Folklore\Image\ImageServiceProvider' not found So, the code of class is not good, i continue my search. EDIT, With 5.7, your plugin works |
I have test and this work.
The major problem is that Laravel 5.8 requires a php version higher than 7.1, so impossible to roolback in the tests
I think the best will be to let version v0.3.25 for laravel 5.7 and pass on a new version for Laravel 5.8 or higher