fix(statusline): set hl_group for statusline separators #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielwe
force-pushed
the
statusline_sep_hl
branch
from
f38e019 to
5ede517
Compare
danielwe
force-pushed
the
statusline_sep_hl
branch
from
5ede517 to
5dd5c9f
Compare
|
This PR is stale because it has been open 30 days with no activity. |
danielwe
force-pushed
the
statusline_sep_hl
branch
from
5dd5c9f to
c07851e
Compare
|
Any comments on this? Been using it locally without issue for a month+. |
|
nvim-lualine/lualine.nvim#1368 was merged, so this is the only piece missing to address the miscolored statusline gaps. Anything you'd like me to do to make this mergeable? |
|
This PR is stale because it has been open 30 days with no activity. |
|
Ready for comments whenever you are :) |
|
This PR is stale because it has been open 30 days with no activity. |
|
keeping this alive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, statusline segments have custom highlight groups, but the separators between the segments don't get any highlight group applied, resulting gaps/discontinuities in the statusline background with most colorschemes. This PR applies the highlight group provided to
trouble.statusline, if any, to the separators as well as to any segments that don't supply their own highlight group.The fix involves a slight refactor of the
fix_statuslinefunctionality such that segment hl backgrounds are substituted in advance rather than via post hoc search and replace.I also added a clause to filter out empty segments which would otherwise result in extraneous separators, usually appended to the end of the statusline string. Let me know if these empty segments/extra separators were intentional and I'll revert that change.
Related Issue(s)
The author closed the issue when a workaround was posted, but I figured it would be worthwhile to fix this properly in the plugin.
Screenshots
Before: Note the gap between
openandview:waitas well as the double gap afterview:waitAfter: The single remaining gap after
view:waitis due to a bug in lualine.nvim; I'm submitting a PR there tooEDIT: With nvim-lualine/lualine.nvim#1368: No gaps!
