[WIP] Azure dependencies updates, some fog-core-2.0 compatibility #407
Conversation
| address_space.address_prefixes = DEFAULT_ADDRESS_PREFIXES | ||
| else | ||
| address_space = Azure::ARM::Network::Models::AddressSpace.new | ||
| address_space = Azure::Network::Profiles::Latest::Mgmt::Models::AddressSpace.new |
There was a problem hiding this comment.
Style/IdenticalConditionalBranches: Move address_space = Azure::Network::Profiles::Latest::Mgmt::Models::AddressSpace.new out of the conditional.
| virtual_network.location = location | ||
| virtual_network.tags = tags | ||
|
|
||
| if address_prefixes.nil? || !address_prefixes.any? | ||
| address_space = Azure::ARM::Network::Models::AddressSpace.new | ||
| address_space = Azure::Network::Profiles::Latest::Mgmt::Models::AddressSpace.new |
There was a problem hiding this comment.
Style/IdenticalConditionalBranches: Move address_space = Azure::Network::Profiles::Latest::Mgmt::Models::AddressSpace.new out of the conditional.
| resource_group, | ||
| nic.public_ip_address_id.split("/").last | ||
| ) | ||
| .ip_address |
There was a problem hiding this comment.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
| .public_ips | ||
| .get( | ||
| resource_group, | ||
| nic.public_ip_address_id.split("/").last |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @public_ip_addresses.push( | ||
| network_service | ||
| .public_ips | ||
| .get( |
There was a problem hiding this comment.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
| def network_service | ||
| storage_service = service.instance_variable_get(:@storage_service) | ||
| @network_Service ||= Fog::Network::AzureRM.new({ | ||
| tenant_id: storage_service.instance_variable_get(:@tenant_id), |
There was a problem hiding this comment.
Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
| @@ -195,8 +198,54 @@ def update_attributes | |||
| merge_attributes(Fog::Compute::AzureRM::Server.parse(vm)) | |||
| end | |||
|
|
|||
| def network_service | |||
| storage_service = service.instance_variable_get(:@storage_service) | |||
| @network_Service ||= Fog::Network::AzureRM.new({ | |||
There was a problem hiding this comment.
Naming/MemoizedInstanceVariableName: Memoized variable @network_Service does not match method name network_service. Use @network_service instead.
Naming/VariableName: Use snake_case for variable names.
Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
| @@ -1,9 +1,11 @@ | |||
| require "fog/compute/models/server" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| end | ||
|
|
||
| def ready? | ||
| provisioning_state == "Succeeded" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| self.sku = { | ||
| name: self.account_type | ||
| } | ||
| elsif self.account_type.nil? && self.sku.nil? |
There was a problem hiding this comment.
Style/RedundantSelf: Redundant self detected.
| rescue MsRestAzure::AzureOperationError => e | ||
| raise_azure_exception(e, msg) | ||
| end | ||
| Fog::Logger.debug "listing all Virtual Machines in subscription successful" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| # Monkey patch for fog-core-2 compatibility | ||
| if disk_name.nil? | ||
| disks = service.list_managed_disks_in_subscription | ||
| disk = disks.each do |disk| |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - disk.
|
|
||
| if self.sku.nil? && !self.account_type.nil? | ||
| self.sku = { | ||
| name: self.account_type |
There was a problem hiding this comment.
Style/RedundantSelf: Redundant self detected.
| validate_creation_data_params(creation_data) | ||
| requires :disk_size_gb | ||
|
|
||
| if self.sku.nil? && !self.account_type.nil? |
There was a problem hiding this comment.
Style/RedundantSelf: Redundant self detected.
|
Hi @stiller-leser . I am currently working on integrating Foreman and AzureRM. In the process, I am also looking into |
|
@apuntamb Just as a headsup, as this PR likely will never be merged, make sure to take a look at my changes for Foreman. The new Azure sdk versions break some things for disk creation. |
| private | ||
|
|
||
| def validate_creation_data_params(creation_data) | ||
| unless creation_data.key?(:create_option) | ||
| raise(ArgumentError, ':create_option is required for this operation') | ||
| if !creation_data || creation_data.create_option.nil? |
There was a problem hiding this comment.
Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.
| private | ||
|
|
||
| def validate_creation_data_params(creation_data) | ||
| if !creation_data || creation_data.create_option.nil? |
There was a problem hiding this comment.
Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.
| end | ||
|
|
||
| def test_model_attributes | ||
| attributes = %i( |
There was a problem hiding this comment.
Style/PercentLiteralDelimiters: %i-literals should be delimited by [ and ].
| end | ||
|
|
||
| def test_collection_methods | ||
| methods = %i(all get) |
There was a problem hiding this comment.
Style/PercentLiteralDelimiters: %i-literals should be delimited by [ and ].
Hi,
I have done some work on the Gem (limited to my purposes). This PR is purely informal and shouldn't be merged. It contains the work of #362, some work for fog-core-2.1 compatibility, an inheritance change for
Server(So that the public ip address could be retrieved and ssh as well as sshable could be used), plus an update to the azure dependencies (and the related changes to the Compute, Network as well as Storage modules). That being said however, all other modules will currently not work (but should easily be adapated).I tried to keep downward compatibility, e.g. for changes to managed disks, however I can not guarantee that I missed something.
Due to time restrictions I won't be able to continue work on other modules, but please feel free to ping me for feedback.
Regards,
stiller-leser