Repository navigation
fix(flyteadmin): preserve deck URI on execution abort - #8161
Merged
Sovietaced merged 1 commit intoOct 11, 2026
Merged
Sovietaced merged 1 commit into
Sovietaced merged 1 commit into
Conversation
When an execution is aborted, the event carries an empty DeckUri which unconditionally overwrites and wipes out the existing DeckUri in the closure. This patch preserves the existing DeckUri if the incoming event's DeckUri is empty. Fixes flyteorg#7610 Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8161 +/- ##
=======================================
Coverage 57.32% 57.33%
=======================================
Files 931 931
Lines 58329 58331 +2
=======================================
+ Hits 33440 33445 +5
+ Misses 21836 21833 -3
Partials 3053 3053
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sovietaced
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Aborting an execution wipes its Flyte Deck URI from the UI because the abort transition event does not attach a deck URI, and
flyteadminunconditionally overwritesclosure.DeckUriwith an empty string. The underlyingdeck.htmlremains in blob storage, but the link in the UI is lost.Following discussion on #7611, this updates
flyteadmin's node execution transformer layer to preserve the existingDeckUriwhen incoming event data carries an empty Deck URI.Fixes #7610
What changes were proposed in this pull request?
flyteadmin/pkg/repositories/transformers/node_execution.go: Only updateclosure.DeckUriiflen(request.GetEvent().GetDeckUri()) > 0, retaining the existing deck URI if the incoming event's Deck URI is empty.flyteadmin/pkg/repositories/transformers/node_execution_test.goverifying that terminal/aborted events and running updates preserve existing deck URIs.How was this patch tested?
Ran
go test -v ./pkg/repositories/transformers/...insideflyteadmin:TestAddTerminalState_PreservesExistingDeckUriWhenEventDeckUriEmptypassed.TestAddNodeRunningState_PreservesExistingDeckUriWhenEventDeckUriEmptypassed.TestUpdateNodeExecutionModel/preserve_deck_uri_on_abortpassed.Labels
Check all the applicable boxes