Skip to content

fix(flyteadmin): preserve deck URI on execution abort - #8161

Merged
Sovietaced merged 1 commit into
flyteorg:masterfrom
muskan-creates352:fix-preserve-deck-uri-abort-7610
Oct 11, 2026
Merged

Sovietaced merged 1 commit into
flyteorg:masterfrom
muskan-creates352:fix-preserve-deck-uri-abort-7610

Conversation

@muskan-creates352

Copy link
Copy Markdown

Why are the changes needed?

Aborting an execution wipes its Flyte Deck URI from the UI because the abort transition event does not attach a deck URI, and flyteadmin unconditionally overwrites closure.DeckUri with an empty string. The underlying deck.html remains in blob storage, but the link in the UI is lost.

Following discussion on #7611, this updates flyteadmin's node execution transformer layer to preserve the existing DeckUri when incoming event data carries an empty Deck URI.

Fixes #7610

What changes were proposed in this pull request?

  • In flyteadmin/pkg/repositories/transformers/node_execution.go: Only update closure.DeckUri if len(request.GetEvent().GetDeckUri()) > 0, retaining the existing deck URI if the incoming event's Deck URI is empty.
  • Added unit tests in flyteadmin/pkg/repositories/transformers/node_execution_test.go verifying that terminal/aborted events and running updates preserve existing deck URIs.

How was this patch tested?

Ran go test -v ./pkg/repositories/transformers/... inside flyteadmin:

  • TestAddTerminalState_PreservesExistingDeckUriWhenEventDeckUriEmpty passed.
  • TestAddNodeRunningState_PreservesExistingDeckUriWhenEventDeckUriEmpty passed.
  • TestUpdateNodeExecutionModel/preserve_deck_uri_on_abort passed.

Labels

  • fixed

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

When an execution is aborted, the event carries an empty DeckUri which unconditionally overwrites and wipes out the existing DeckUri in the closure. This patch preserves the existing DeckUri if the incoming event's DeckUri is empty.

Fixes flyteorg#7610

Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
@github-actions github-actions Bot added the flyte label Oct 11, 2026
@codecov

codecov Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.33%. Comparing base (fdbd064) to head (e34c824).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8161   +/-   ##
=======================================
  Coverage   57.32%   57.33%           
=======================================
  Files         931      931           
  Lines       58329    58331    +2     
=======================================
+ Hits        33440    33445    +5     
+ Misses      21836    21833    -3     
  Partials     3053     3053           
Flag Coverage Δ
unittests-datacatalog 53.62% <ø> (ø)
unittests-flyteadmin 53.26% <100.00%> (+0.01%) ⬆️
unittests-flytecopilot 48.05% <ø> (ø)
unittests-flytectl 64.11% <ø> (ø)
unittests-flyteidl 76.63% <ø> (ø)
unittests-flyteplugins 60.64% <ø> (ø)
unittests-flytepropeller 53.84% <ø> (ø)
unittests-flytestdlib 64.41% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Sovietaced
Sovietaced merged commit 9ea5e44 into flyteorg:master Oct 11, 2026
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants