Skip to content

Add hooks to run before and after the popup appear #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lthms wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add hooks to run before and after the popup appear #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions flycheck-popup-tip.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,18 @@
(defvar flycheck-popup-tip-old-display-function nil
"The former value of `flycheck-display-errors-function'.")

(defvar flycheck-popup-tip-show-hook nil
"Hook run before when showing a popup.")

(defvar flycheck-popup-tip-delete-hook nil
"Hook run before when deleting a popup.")

(defun flycheck-popup-tip-delete-popup ()
"Delete messages currently being shown if any."
(remove-hook 'pre-command-hook 'flycheck-popup-tip-delete-popup t)
(when (popup-live-p flycheck-popup-tip-object)
(popup-delete flycheck-popup-tip-object))
(remove-hook 'pre-command-hook 'flycheck-popup-tip-delete-popup t))
(popup-delete flycheck-popup-tip-object)
(run-hook-with-args 'flycheck-popup-tip-delete-hook)))

(defun flycheck-popup-tip-format-errors (errors)
"Formats ERRORS messages for display."
Expand All @@ -97,6 +104,7 @@
"Display ERRORS, using popup.el library."
(flycheck-popup-tip-delete-popup)
(when errors
(run-hook-with-args 'flycheck-popup-tip-show-hook)
(setq flycheck-popup-tip-object
(popup-tip
(flycheck-popup-tip-format-errors errors)
Expand Down