Enable the checker in .merlin presence - #16
Open
temyurchenko wants to merge 1 commit into
Open
temyurchenko wants to merge 1 commit into
temyurchenko wants to merge 1 commit into
Conversation
Author
|
Please, do note that I am not proficient in the OCaml ecosystem and have tested this only on a one-file project. That might entail needing extra attention when reviewing the PR :D |
Problem: some projects don't use Dune, while using Merlin, configured with the .merlin file. `flycheck-ocaml` is only turned on if the «dune-project» file is present though. As a result, `flycheck-ocaml` is disabled for such projects. Solution: enable the `flycheck-ocaml` checker if either dune-project or .merlin are present. In a round-about way this fixes flycheck#15. People who don't use Dune, don't need to create an empty dune-project to use the checker, which was misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: some projects don't use Dune, while using Merlin, configured
with the .merlin file.
flycheck-ocamlis only turned on if the«dune-project» file is present though. As a result,
flycheck-ocamlis disabled for such projects.Solution: enable the
flycheck-ocamlchecker if either dune-projector .merlin are present.
In a round-about way this fixes #15. People who don't use Dune, now
don't need to create an empty dune-project to use the checker, which
was misleading.