Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/mfd): Added FCU backup AFS control basic layout. #9628

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

EA888-3B
Copy link

@EA888-3B EA888-3B commented Dec 6, 2024

Fixes #[issue_no]

Summary of Changes

Created basic layout of FCU backup AFS control panel. No functions. Some of the button has FCU physical button style (like the toggle button and the autopilot ones) and its not added yet.

Screenshots (if necessary)

fcubackup

References

A350 MFD manual. I dont have A380 ref but If some one has A380 FCU backup ref, please compare, and let me know if there is any difference.

Additional context

Discord username (if different from GitHub): Olympus593

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@heclak
Copy link
Contributor

heclak commented Dec 8, 2024

I didn't dig too deep into the details but the A380 has the tabs in a different order. It is EFIS CP first then AFS CP. I recommend using the A380 manual directly instead of using an A350 manual. The avionics pages aren't always the same between the two aircraft.

@EA888-3B
Copy link
Author

EA888-3B commented Dec 8, 2024

I didn't dig too deep into the details but the A380 has the tabs in a different order. It is EFIS CP first then AFS CP. I recommend using the A380 manual directly instead of using an A350 manual. The avionics pages aren't always the same between the two aircraft.

You are correct, its that order from my 350 ref as well. I did not change the code of the tab, it was written before. Im working on the EFIS right now, and once all the layout is done, I will update it. And I am pretty sure that tab is reversed between FMS1 and FMS2, since the FO has an other direction of FCU access.

I just want to get the basic layout out there so if there is anyone instrested adding the function can add right on it. Right now Im still reading and understanding the logic and fuctions of the ND and FCU, I dont really have a starting point yet.

@heclak
Copy link
Contributor

heclak commented Dec 9, 2024

Yes. It's much more helpful if you can verify the layout/changes by using the correct manual instead of the reviewers needing to spot the differences again knowing you are using the wrong manual in the first place. Also, small things like you mention about FO layouts might vary across airframes, not sure how to verify this though. Do put in the relevant references and their source in your PR so it's easier for the reviewer to verify. If it's multiple pages of the FCOM, you can put the page numbers that you referred to too.

Knowing the function is also useful for evaluating how to code/prepare some UI logic for the person coding the function (if that person isn't you). You can also reach out on discord to see if anyone can provide details that is outside of the FCOM.

@Benjozork Benjozork added the A380X Related to the A380X aircraft label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants