-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift Package Manager Support (closes #80) #90
base: main
Are you sure you want to change the base?
Conversation
@Gustl22 thanks for your pending changes. Once they're out of draft, then I'll start running automation against them. |
Just need to try, if my changes actually work ^^ ;D |
Seems to compile, can't really test, as there's a limitation with the simulator that it does not go into sleep by itself (and I don't have a real device): I can come back with the results in a few days, or you can test for yourself. But as it compiles and the logic hasn't changed it should most likely work. |
That's definitely a known issue. You'll need a real device to verify that it works. As long as you're able to get to the method channel from iOS regardless of device, then that suffices for this PR. |
@Gustl22 Looks like you need to apply Dart formatting. |
I did a reformat, hopefully that was everything, that was missing. |
@Gustl22 please fix the Deprecations that they're asking about. Thanks. |
The deprecation is not part of the SPM change, I created #92 for that. |
Please re-sync your changes with |
@diegotori thanks 🙏 i updated this branch 👍 |
Just as note: This change passed our internal test. |
@Gustl22 understood. I'll release this as a new minor version later today. Thanks for your contribution. |
Awesome thank you for maintaining! |
@loic-sharma Please let me know if this SPM integration looks good to you. Thanks. Before I approve it, if you're happy with it, then I am too. |
Description
Closes #80