Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager Support (closes #80) #90

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Gustl22
Copy link
Contributor

@Gustl22 Gustl22 commented Mar 24, 2025

Description

Closes #80

@diegotori
Copy link
Collaborator

@Gustl22 thanks for your pending changes. Once they're out of draft, then I'll start running automation against them.

@Gustl22
Copy link
Contributor Author

Gustl22 commented Mar 24, 2025

Just need to try, if my changes actually work ^^ ;D

@Gustl22
Copy link
Contributor Author

Gustl22 commented Mar 24, 2025

Seems to compile, can't really test, as there's a limitation with the simulator that it does not go into sleep by itself (and I don't have a real device):
https://stackoverflow.com/questions/10955942/how-to-simulate-iphone-being-put-to-sleep-in-ios-simulator

I can come back with the results in a few days, or you can test for yourself. But as it compiles and the logic hasn't changed it should most likely work.

@Gustl22 Gustl22 marked this pull request as ready for review March 24, 2025 15:28
@diegotori
Copy link
Collaborator

Seems to compile, can't really test, as there's a limitation with the simulator that it does not go into sleep by itself (and I don't have a real device): https://stackoverflow.com/questions/10955942/how-to-simulate-iphone-being-put-to-sleep-in-ios-simulator

That's definitely a known issue. You'll need a real device to verify that it works. As long as you're able to get to the method channel from iOS regardless of device, then that suffices for this PR.

@diegotori
Copy link
Collaborator

@Gustl22 Looks like you need to apply Dart formatting.

@Gustl22
Copy link
Contributor Author

Gustl22 commented Mar 25, 2025

I did a reformat, hopefully that was everything, that was missing.

@diegotori
Copy link
Collaborator

@Gustl22 please fix the Deprecations that they're asking about. Thanks.

@Gustl22
Copy link
Contributor Author

Gustl22 commented Mar 26, 2025

The deprecation is not part of the SPM change, I created #92 for that.

@diegotori
Copy link
Collaborator

Please re-sync your changes with main, since I published your win32 changes. Thanks.

@Gustl22
Copy link
Contributor Author

Gustl22 commented Mar 27, 2025

@diegotori thanks 🙏 i updated this branch 👍

@Gustl22
Copy link
Contributor Author

Gustl22 commented Apr 2, 2025

Just as note: This change passed our internal test.

@diegotori
Copy link
Collaborator

@Gustl22 understood. I'll release this as a new minor version later today. Thanks for your contribution.

@Gustl22
Copy link
Contributor Author

Gustl22 commented Apr 2, 2025

Awesome thank you for maintaining!

@diegotori
Copy link
Collaborator

@loic-sharma Please let me know if this SPM integration looks good to you. Thanks.

Before I approve it, if you're happy with it, then I am too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Swift Package Manager support
2 participants