Skip to content

Conversation

ViscousPot
Copy link
Contributor

@ViscousPot ViscousPot commented Dec 23, 2024

Description

This package already has the ability to send arbitrary intents to an activity or broadcast receiver.
This PR adds the ability to send intents to a service using sendService

Related Issues

No related issues exist for this

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@ViscousPot ViscousPot marked this pull request as draft December 23, 2024 11:09
@ViscousPot ViscousPot marked this pull request as ready for review December 24, 2024 08:03
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I will have to test it on my device before approving and merging. Meanwhile, there are a couple of lines that require changes.

@miquelbeltran
Copy link
Member

Sorry this fell off my plate, I fixed the merge conflict after merging your other PR, I'll see if I can work on this soon

@miquelbeltran miquelbeltran dismissed their stale review February 1, 2025 09:56

changes done but pending review

@miquelbeltran miquelbeltran merged commit ea72b63 into fluttercommunity:main Feb 3, 2025
11 checks passed
@miquelbeltran
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants