Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/a2ui_agent/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## 0.0.1-wip
## 0.0.1-wip002

- Initial version.
2 changes: 1 addition & 1 deletion packages/a2ui_agent/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# A2UI Agent SDK
# A2UI Flutter SDK

TODO: add readme
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:a2ui_agent/a2ui_agent.dart';
import 'package:a2ui_flutter/a2ui_flutter.dart';

void main() {
var awesome = Awesome();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
/// More dartdocs go here.
library;

export 'src/a2ui_agent_base.dart';
export 'src/a2ui_flutter_base.dart';

// TODO: Export any libraries intended for clients of this package.
9 changes: 5 additions & 4 deletions packages/a2ui_agent/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

name: a2ui_agent
description: The A2UI agent SDK.
version: 0.0.1-wip
repository: https://github.com/flutter/genui/tree/main/packages/a2ui_agent
name: a2ui_flutter
description: The A2UI Flutter SDK.
version: 0.0.1-wip002
repository: https://github.com/flutter/genui/tree/main/packages/a2ui_flutter

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository URL points to packages/a2ui_flutter, but the directory in this pull request is still named packages/a2ui_agent. This mismatch will result in a broken link on pub.dev. If the directory renaming is planned for a later step, please keep this in mind; otherwise, the URL should be updated to match the actual directory path.


resolution: workspace

Expand All @@ -14,6 +14,7 @@ environment:

dependencies:
a2ui_core: ^0.1.0
json_schema_builder: ^0.1.3
Comment on lines 16 to +17

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The json_schema_builder dependency is added here but does not appear to be directly imported or used anywhere in this package. Since a2ui_core already depends on it, and this package only depends on a2ui_core, this direct dependency is redundant and can be removed.

  a2ui_core: ^0.1.0


dev_dependencies:
test: ^1.26.2
2 changes: 1 addition & 1 deletion packages/a2ui_agent/test/a2ui_agent_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:a2ui_agent/a2ui_agent.dart';
import 'package:a2ui_flutter/a2ui_flutter.dart';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test file is still named a2ui_agent_test.dart even though the package and its main library have been renamed to a2ui_flutter. Renaming this file to a2ui_flutter_test.dart would maintain consistency with the new package name.

import 'package:test/test.dart';

void main() {
Expand Down
Loading