[video_player_avplay]Add setData and getData interface

[xiaowei-guan]

#821

new interface setData and getData for dash player:

enum DashPlayerProperty {
  /// Max band width of dash player, the value is int.
  maxBandWidth,

  /// Dash player stream info, the value is json string.
  dashStreamInfo,
}

/// Set dashplayer properties,can be called after initialized.
  Future<bool> setData(int playerId, Map<DashPlayerProperty, Object> data);

  /// Get dashplayer properties,can be called after initialized.
  Future<Map<DashPlayerProperty, Object>> getData(
    int playerId,
    Set<DashPlayerProperty> keys,
  );

[JSUYA]

Before I get into review...
rapid json is an external library. If clang-format updated rapidjson should also be updated.
How about applying .clang-format-ignore?

[xiaowei-guan]

.clang-format-ignore for rapidjson.> Before I get into review... rapid json is an external library. If clang-format updated rapidjson should also be updated. How about applying .clang-format-ignore?

I have tried to use .clang-format-ignore, but it doesn't work.
I viewed the tools_runner.sh, I found that it uses flutter_plugins_tools plugin to run clang-format command.
but it doesn't have ignore option. Have you used .clang-fromat-ignore before?

[xiaowei-guan]

.clang-format-ignore for rapidjson.> Before I get into review... rapid json is an external library. If clang-format updated rapidjson should also be updated. How about applying .clang-format-ignore?

I have tried to use .clang-format-ignore, but it doesn't work. I viewed the tools_runner.sh, I found that it uses flutter_plugins_tools plugin to run clang-format command. but it doesn't have ignore option. Do you konw how to use .clang-fromat-ignore ?

[JSUYA]

I have tried to use .clang-format-ignore, but it doesn't work. I viewed the tools_runner.sh, I found that it uses flutter_plugins_tools plugin to run clang-format command. but it doesn't have ignore option. Have you used .clang-fromat-ignore before?

Oh I'm sorry. I tested it wrong, I was under the mistaken think that it worked.
For now, please applying format. in the future i will check way to bypass clang-format.

[JSUYA]

Should this API also be called in advance like setStreamingProperty?

[JSUYA]

You can get type from value. so you don't add reverse_map.

return <DashPlayerProperty, Object>{
      for (final MapEntry<Object?, Object?> entry in msg.data.entries)
        _dashPlayerPropertyMap.keys.firstWhere((DashPlayerProperty key) =>
            _dashPlayerPropertyMap[key] == entry.key!): entry.value!,
    };

+)
Can you provide me some code to test this feature?
I tested it like this in the example but I couldn't get any result.

Map<DashPlayerProperty, Object> data = {
      DashPlayerProperty.maxBandWidth: 15000,
      // DashPlayerProperty.mpeghMetadata: 'METADATA TEST',
    };
    _controller.setData(data);

    _controller.setLooping(true);
    _controller.initialize().then((_) => setState(() {
          final Set<DashPlayerProperty> keys = {
            DashPlayerProperty.maxBandWidth,
            // DashPlayerProperty.mpeghMetadata
          };
          _controller.getData(keys).then((onValue) => print(onValue));
        }));

[xiaowei-guan]

Done,

setData must call after initialize successful.
but it staill has issue with mpeghMetadata, I'm checking with MM team.

[JSUYA]

setData must call after initialize successful.

Could you please add this explanation to the comments or README?
+) As far as I know, setStreamingProperty should be called before initialization.
Please also include this content in the comments or README.

[xiaowei-guan]

Done

[JSUYA]

Does this API only provide DashProperty? Are there any plans to provide other properties?

[JSUYA]

but it staill has issue with mpeghMetadata, I'm checking with MM team.

Once this is fixed, please verify the behavior and merge.

[xiaowei-guan]

but it staill has issue with mpeghMetadata, I'm checking with MM team.

Once this is fixed, please verify the behavior and merge.

The MM team member said that mpeghMetadata doesn't open for 3rd-party, I have deleted it form DashPropertyType enum.