build: remove buster, replace with bullseye when necessary #10908

aminvakil · 2025-09-19T14:03:48Z

It's been three years since buster does not gets updated from Debian Security Team and it's been a year since Debian LTS Team does not support that either.

Now that trixie has been added as well to this repository, I've removed all buster tests.

There were also some tests which only were tested on buster, I've changed them to bullseye for now to expect minimum changes, and I'm going to change them to trixie with is Debian stable now.

Enter `` in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

[N/A] Example configuration file for the change
[N/A] Debug log output from testing the change
[N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Run local packaging test showing all targets (including any new ones) build.
Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

Documentation required for this feature

fluent/fluent-bit-docs#2068

Backporting

[N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

Chores
- Migrated build environment from Debian 10 (Buster) to Debian 11 (Bullseye).
- Removed Buster repositories and targets from packaging and repo update processes.
Documentation
- Updated packaging documentation to remove Debian 10 (Buster) entries and reflect current supported distributions.
Packaging
- Pruned Debian 10 (Buster) targets from build configurations to align with supported platforms.
Style
- Minor formatting cleanup in build configuration files with no functional impact.

patrick-stephens

I would disable the build but not remove the option for folks to build, I know it's eol but that's not the same as no one uses it (look at Centos). We can just remove it from all the CI but leave the container definition I think.

aminvakil · 2025-09-19T14:36:32Z

I would disable the build but not remove the option for folks to build, I know it's eol but that's not the same as no one uses it (look at Centos). We can just remove it from all the CI but leave the container definition I think.

65c15b4

Does this suffice?

patrick-stephens · 2025-09-20T19:06:30Z

.github/actions/generate-package-build-matrix/action.yaml

          echo '{ "distro" : ['
          echo '"amazonlinux/2", "amazonlinux/2.arm64v8",'
          echo '"centos/7", "centos/7.arm64v8", "centos/8", "centos/8.arm64v8",'
-          echo '"debian/buster", "debian/buster.arm64v8", "debian/bullseye", "debian/bullseye.arm64v8",'


No need to change this, it's only for 1.9 and earlier builds

patrick-stephens · 2025-09-20T19:08:20Z

packaging/distros/raspbian/Dockerfile

 # Use buildkit to skip unused base images: DOCKER_BUILDKIT=1

-FROM balenalib/rpi-raspbian:buster AS raspbian-buster-base
+FROM balenalib/rpi-raspbian:bullseye AS raspbian-bullseye-base


This is actually changing the Raspbian build, I'm not sure we want that as it's not Debian per-se. Not sure why we jumped from buster to bookworm for Raspbian but that's not part of this change.

Please make sure you're not just globally changing any reference to the string.

patrick-stephens · 2025-09-20T19:09:16Z

packaging/testing/smoke/packages/Dockerfile.debian10

@@ -1,11 +1,11 @@
 # For staging upgrade we use the 'official-install' as the base
-ARG STAGING_BASE=docker.io/dokken/debian-10
+ARG STAGING_BASE=docker.io/dokken/debian-11


Again, this is a change that is confusing as the file we are in here is called .debian10, I think it's been a global search-and-replace when instead we should also rename the file to be clear and accurate.

Sorry, this was a mistake and I have reverted this.

Yes. It was a global search-and-replace. I wasn't sure if this file is still needed, so I have not removed it and just reverted my wrong change.

aminvakil · 2025-09-26T11:26:56Z

None of failing tests are related to this PR.

Signed-off-by: Amin Vakil <[email protected]>

coderabbitai · 2025-09-26T11:27:28Z

Walkthrough

CI workflows switch Debian base from buster to bullseye across multiple libraries. Packaging drops Debian 10 (buster) targets and references. One script removes buster from repository paths; another updates a comment. A CMakeLists file gains a final newline without functional change.

Changes

Cohort / File(s)	Summary of changes
GitHub Actions: Debian Bullseye migration `lib/cfl/.github/workflows/build.yaml`, `lib/cmetrics/.github/workflows/build.yaml`, `lib/cprofiles/.github/workflows/build.yaml`, `lib/ctraces/.github/workflows/build.yaml`	Rename Debian job from “Buster” to “Bullseye” and update container image from `debian:buster` to `debian:bullseye`; no step or flow changes.
Packaging targets cleanup (remove Debian 10/buster) `packaging/README.md`, `packaging/build-config.json`	Remove Debian 10/buster entries from distro table and from `linux_targets` (both x86_64 and arm64v8).
Repo update scripts `packaging/update-repos.sh`, `packaging/update-apt-repo.sh`	Drop `debian/buster` from update paths; adjust commented DEB_REPO options (remove debian/raspbian buster). Logic unchanged.
Build system formatting `src/wamrc/CMakeLists.txt`	Add proper final newline/endif; no functional changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

niedbalski
celalettin1286

Poem

Hop-hop, I pack my bits so spry,
Buster’s burrow, a wave goodbye.
Bullseye fields in fresher light,
Repos trimmed, the path set right.
CI drums a steady beat—
New carrots, same swift feet! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly conveys the primary change of the pull request, namely removing Debian Buster and replacing it with Bullseye where required. It clearly reflects the modifications across CI workflows and packaging files without including extraneous details. A teammate scanning the history would understand the main intent from this title.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d21e8de and 586e9b3.

📒 Files selected for processing (9)

lib/cfl/.github/workflows/build.yaml (1 hunks)
lib/cmetrics/.github/workflows/build.yaml (1 hunks)
lib/cprofiles/.github/workflows/build.yaml (1 hunks)
lib/ctraces/.github/workflows/build.yaml (1 hunks)
packaging/README.md (0 hunks)
packaging/build-config.json (0 hunks)
packaging/update-apt-repo.sh (1 hunks)
packaging/update-repos.sh (0 hunks)
src/wamrc/CMakeLists.txt (1 hunks)

💤 Files with no reviewable changes (3)

packaging/update-repos.sh
packaging/build-config.json
packaging/README.md

🔇 Additional comments (6)

lib/ctraces/.github/workflows/build.yaml (1)

82-85: Bullseye target switch looks solid

Switching the Debian matrix job to debian:bullseye aligns with current Debian support horizons and keeps the dependency bootstrap identical, so the workflow continues to build under the maintained release train.

lib/cfl/.github/workflows/build.yaml (1)

103-106: Consistent Debian image upgrade

The move to the Bullseye container matches the other component workflows and keeps the setup steps unchanged, so coverage on the supported distro stays intact.

lib/cmetrics/.github/workflows/build.yaml (1)

87-90: Debian Bullseye build path confirmed

The container bump and job rename keep the toolchain bootstrap in sync with the upstream project state without altering the build/test flow.

packaging/update-apt-repo.sh (1)

13-13: Comment matches the supported repo set

Updating the documented DEB_REPO options to drop buster and list the remaining distributions keeps the guidance in lockstep with the packaging configuration.

lib/cprofiles/.github/workflows/build.yaml (1)

78-81: Bullseye adoption aligns with packaging changes

Renaming the job and switching to the Bullseye container ensures the workflow targets the maintained Debian release while leaving the build/test recipe intact.

src/wamrc/CMakeLists.txt (1)

255-255: No functional impact detected

Bringing the closing endif () back with a proper newline is harmless and keeps the formatting consistent.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

aminvakil requested review from niedbalski, patrick-stephens, celalettin1286, edsiper, fujimotos and koleini as code owners September 19, 2025 14:03

github-actions bot added the docs-required label Sep 19, 2025

aminvakil mentioned this pull request Sep 19, 2025

packaging: remove buster fluent/fluent-bit-docs#2068

Open

patrick-stephens reviewed Sep 19, 2025

View reviewed changes

patrick-stephens reviewed Sep 20, 2025

View reviewed changes

aminvakil force-pushed the remove_buster branch 2 times, most recently from 3a514d9 to 6304625 Compare September 20, 2025 23:14

aminvakil added 5 commits September 26, 2025 14:57

build: remove buster, replace with bullseye when necessary

e512e66

Signed-off-by: Amin Vakil <[email protected]>

Add buster Dockerfile back

0db46ca

Signed-off-by: Amin Vakil <[email protected]>

Revert raspbian Dockerfile changes

317b4df

Signed-off-by: Amin Vakil <[email protected]>

Revert Dockerfile.debian10 changes

483d5e8

Signed-off-by: Amin Vakil <[email protected]>

Revert 1.9 action.yaml changes

586e9b3

Signed-off-by: Amin Vakil <[email protected]>

aminvakil force-pushed the remove_buster branch from 6304625 to 586e9b3 Compare September 26, 2025 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build: remove buster, replace with bullseye when necessary #10908

build: remove buster, replace with bullseye when necessary #10908

aminvakil commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

patrick-stephens left a comment

Uh oh!

aminvakil commented Sep 19, 2025

Uh oh!

patrick-stephens Sep 20, 2025

Uh oh!

aminvakil Sep 20, 2025

Uh oh!

patrick-stephens Sep 20, 2025

Uh oh!

aminvakil Sep 20, 2025

Uh oh!

patrick-stephens Sep 20, 2025

Uh oh!

aminvakil Sep 20, 2025

Uh oh!

aminvakil commented Sep 26, 2025

Uh oh!

coderabbitai bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

build: remove buster, replace with bullseye when necessary #10908

Are you sure you want to change the base?

build: remove buster, replace with bullseye when necessary #10908

Conversation

aminvakil commented Sep 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

patrick-stephens left a comment

Choose a reason for hiding this comment

Uh oh!

aminvakil commented Sep 19, 2025

Uh oh!

patrick-stephens Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

aminvakil Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

patrick-stephens Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

aminvakil Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

patrick-stephens Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

aminvakil Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

aminvakil commented Sep 26, 2025

Uh oh!

coderabbitai bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

aminvakil commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 26, 2025 •

edited

Loading