-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support vhost-style S3 URLs #10878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miquelruiz
wants to merge
6
commits into
fluent:master
Choose a base branch
from
miquelruiz:mruiz/vhost-style-s3-url
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+182
−65
Open
Support vhost-style S3 URLs #10878
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f3b0cb6
Option to force vhost-style URLs
miquelruiz 338d252
Encapsulate endpoint init into a function
miquelruiz 659ddcf
Prefix S3 domain with bucket
miquelruiz 0af1d44
Remove bucket from Put's path
miquelruiz 3c5b989
Remove bucket from multi-part upload path
miquelruiz 7e50f95
Unit test for vhost-style urls
miquelruiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify bucket name compatibility with vhost-style URLs.
When using vhost-style URLs, bucket names must be DNS-compliant. The code should validate that the bucket name doesn't contain characters that would make it invalid as a DNS hostname (e.g., underscores, uppercase letters).
Consider adding validation for DNS-compliant bucket names when vhost-style URLs are enabled:
🏁 Script executed:
Length of output: 107459
Validate bucket name before constructing vhost-style endpoint (DNS‑compliant).
plugins/out_s3/s3.c (around lines 650–674) currently concatenates ctx->bucket and ctx->endpoint into a hostname without validating the bucket. Add a DNS-compatibility check and fall back to path-style (or return an error) when the bucket is not DNS-compatible. Enforce: 3–63 chars; only lowercase letters, digits, hyphen and dot; start/end with letter or digit; no consecutive dots; not IPv4-formatted. A practical check: regex ^[a-z0-9][a-z0-9.-]{1,61}[a-z0-9]$ AND reject /(\d+.){3}\d+/ and '..' before using vhost-style formatting.