-
Notifications
You must be signed in to change notification settings - Fork 1.7k
workflows: prepare 4.1 release #10611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
558eb4b
to
96017a0
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
We still need to release 4.0 as a stable version. So, we still needed to use latest tag as a 4.0.x versions. Signed-off-by: Hiroshi Hatake <[email protected]>
96017a0
to
e4c95f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say let's have this PR ready to go for 4.1 with all changes - merging some but not all may be annoying.
I would split it out into a PR for making 4.1 the latest and then one we merge now for unit tests and nightly builds to use the right branches.
@@ -22,6 +22,7 @@ on: | |||
- 'examples/**' | |||
branches: | |||
- master | |||
- 4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the nightly builds cron to pick the right branches?
@@ -840,6 +842,17 @@ jobs: | |||
tag_name: v${{ inputs.version }} | |||
make_latest: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say we change this now and do not merge PR until it is ready to release. Otherwise we have to change it later.
Sure, I'll do it. Or, you are going to merge nightly build and unit-test parts at first? It'll be also fine for me. |
Currently, still left for 4.0 release adopted workflows.
So, we need to change the settings to prepare 4.1 release.
For now, we still need to use latest tag for 4.0 release. So, I didn't touch it.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.