in_winevtlog: Launch w/o valid subscription when using ignore_missing_channels parameter [Backport 3.2] #10564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_channels parameter When using small amount of log volume but sometimes absent channels, users are forcibly ought to specify with the defenetely existing channels together. This causes glitches of log flow controls. So, we decided to permit absence of valid channel subscriptions when using ignore_missing_channels parameter. This permits to use sometimes absent but low log volume and needed to consume A-to-Z EventLog channels. Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting PR of #10555
When using small amount of log volume but sometimes absent channels, users are forcibly ought to specify with the defenetely existing channels together.
This causes glitches of log flow controls.
So, we decided to permit absence of valid channel subscriptions when using ignore_missing_channels parameter.
This permits to use sometimes absent but low log volume and needed to consume A-to-Z EventLog channels.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.