Skip to content

Reset pod and namespace watch retry count and backoff interval on successful events and add unit tests. #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcantrill merged 2 commits into from
Mar 22, 2020
Merged

Reset pod and namespace watch retry count and backoff interval on successful events and add unit tests. #219

jcantrill merged 2 commits into from
Mar 22, 2020

Conversation

@qingling128
Copy link
Contributor

@qingling128 qingling128 commented Mar 22, 2020 •
edited
Loading

Fixes this:

image

@qingling128 qingling128 mentioned this pull request Mar 22, 2020
Merged
@qingling128
Copy link
Contributor Author

qingling128 commented Mar 22, 2020

Side note: Can we do a release after this one is done? The latest commits seem to make a big improvement regarding performance (more details in #214 (comment)).

@qingling128 qingling128 force-pushed the lingshi-reset branch 2 times, most recently from bd9da1c to 696eb45 Compare March 22, 2020 19:59
@qingling128
Reset pod_watch_retry_backoff_interval for successful watch events an…
0af79a1 
…d add more tests around pod watch.

Change-Id: I603f2a3a1cc35be66ef0e5ea89d373245415c341
@qingling128 qingling128 changed the title Reset pod_watch_retry_backoff_interval to 0 for successful watch events. Reset pod_watch_retry_backoff_interval for successful watch events and add more tests around pod watch. Mar 22, 2020
@qingling128
Apply the same changes to namespace watch and add tests as well.
75525ca 
Change-Id: I603052bd8b892fb45b21037840a4a1b1ada06cc2
@qingling128 qingling128 changed the title Reset pod_watch_retry_backoff_interval for successful watch events and add more tests around pod watch. Reset pod and namespace watch retry count and backoff interval on successful events and add unit tests. Mar 22, 2020
@qingling128
Copy link
Contributor Author

qingling128 commented Mar 22, 2020

Added more unit tests and also apply the change to namespace watches. Ready for review now.

@jcantrill jcantrill merged commit faff00c into fluent-plugins-nursery:master Mar 22, 2020
@qingling128 qingling128 deleted the lingshi-reset branch March 23, 2020 00:07
@jcantrill
Copy link
Contributor

jcantrill commented Mar 23, 2020

https://rubygems.org/gems/fluent-plugin-kubernetes_metadata_filter/versions/2.4.5

@qingling128
Copy link
Contributor Author

qingling128 commented Mar 23, 2020

Thanks @jcantrill !

@qingling128 qingling128 mentioned this pull request Mar 23, 2020
Merged
@andrzej-stencel andrzej-stencel mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qingling128 @jcantrill