-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Structure for the Abstract Interpretation #397
Basic Structure for the Abstract Interpretation #397
Conversation
As it is automatically included Co-authored-by: Florian Sihler <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
+ Coverage 71.24% 71.49% +0.24%
==========================================
Files 215 217 +2
Lines 6858 6984 +126
Branches 1061 1084 +23
==========================================
+ Hits 4886 4993 +107
- Misses 1691 1704 +13
- Partials 281 287 +6 ☔ View full report in Codecov by Sentry. |
Just a note so we do not forget it:
|
test/functionality/abstract-interpretation/abstract-interpretation.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make ready for merge!
test/functionality/abstract-interpretation/abstract-interpretation.spec.ts
Show resolved
Hide resolved
test/functionality/abstract-interpretation/abstract-interpretation.spec.ts
Show resolved
Hide resolved
@EagleoutIce So I cleared all open comments / TODOs. Theoretically, this PR should be mergeable now. Buuuuut AI still makes many tests fail (mainly 'cause we don't know how to handle many cases). I think it's also a long term goal to make AI fail silently. Is this something for a new issue, or should this be implemented in this PR? |
As far as I am concerned, at least passing these tests (e.g., by removing AI from the main pipeline for now) should be part of this PR. |
As soon as abstract interpretation stops making the tests fail, we can safely put it back in :^)
No description provided.