Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abstract Domains IV] A resolve value query #1267

Merged
merged 14 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/documentation/print-query-wiki.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,28 @@ ${
}
});

registerQueryDocumentation('resolve-value', {
name: 'Resolve Value Query',
type: 'active',
shortDescription: 'Provides access to flowR\'s alias tracking',
gigalasr marked this conversation as resolved.
Show resolved Hide resolved
functionName: executeSearch.name,
functionFile: '../queries/catalog/resolve-value-query/resolve-value-query-executor.ts',
buildExplanation: async(shell: RShell) => {
const exampleCode = 'x <- 1\nprint(x)';
return `
With this query you can use flowR's alias-tracking capabilities to resolve identifiers to their values.
gigalasr marked this conversation as resolved.
Show resolved Hide resolved

Using the example code \`${exampleCode}\`, the following query returns all values of 'x' in the code:
${
await showQuery(shell, exampleCode, [{
type: 'resolve-value',
criteria: ['2@x']
}], { showCode: true })
}
`;
}
});

registerQueryDocumentation('search', {
name: 'Search Query',
type: 'active',
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import type { ResolveValueQuery, ResolveValueQueryResult } from './resolve-value-query-format';
import { log } from '../../../util/log';
import type { BasicQueryData } from '../../base-query-format';
import { slicingCriterionToId } from '../../../slicing/criterion/parse';
import { resolveToValues } from '../../../dataflow/environments/resolve-by-name';
import { recoverName } from '../../../r-bridge/lang-4.x/ast/model/processing/node-id';

export function fingerPrintOfQuery(query: ResolveValueQuery): string {
return JSON.stringify(query);
}

export function executeResolveValueQuery({ dataflow: { graph, environment } }: BasicQueryData, queries: readonly ResolveValueQuery[]): ResolveValueQueryResult {
const idMap = graph.idMap;

if(!idMap) {
throw new Error('idMap was undefined');
}
gigalasr marked this conversation as resolved.
Show resolved Hide resolved

const start = Date.now();
const results: ResolveValueQueryResult['results'] = {};
for(const query of queries) {
const key = fingerPrintOfQuery(query);

if(results[key]) {
log.warn(`Duplicate Key for slicing-query: ${key}, skipping...`);
gigalasr marked this conversation as resolved.
Show resolved Hide resolved
}

const values = query.criteria
.map(criteria => recoverName(slicingCriterionToId(criteria, idMap), idMap))
.flatMap(ident => resolveToValues(ident, environment, graph));

results[key] = {
values: [... new Set(values)]
};
}

return {
'.meta': {
timing: Date.now() - start
},
results
};
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import type { BaseQueryFormat, BaseQueryResult } from '../../base-query-format';

import type { SlicingCriteria } from '../../../slicing/criterion/parse';
import type { QueryResults, SupportedQuery } from '../../query';
import { bold } from '../../../util/ansi';
import { printAsMs } from '../../../util/time';
import Joi from 'joi';

import { executeResolveValueQuery } from './resolve-value-query-executor';
import type { RNumberValue, RStringValue } from '../../../r-bridge/lang-4.x/convert-values';


export interface ResolveValueQuery extends BaseQueryFormat {
readonly type: 'resolve-value';
/** The slicing criteria to use */
readonly criteria: SlicingCriteria,
}

export interface ResolveValueQueryResult extends BaseQueryResult {
results: Record<string, {values: unknown[]}>
}

function rValueToAscii(value: string | RNumberValue | RStringValue): string {
if(value === null || value === undefined) {
return 'undefined';
} else if(typeof value === 'string') {
return value;
} else if(typeof value === 'object') {
if('num' in value) {
EagleoutIce marked this conversation as resolved.
Show resolved Hide resolved
return value.num.toString();
} else if('str' in value) {
return `${value.quotes}${value.str}${value.quotes}`;
} else {
console.warn('omega lul');
return JSON.stringify(value);
}
}

return value;
}

export const ResolveValueQueryDefinition = {
executor: executeResolveValueQuery,
asciiSummarizer: (formatter, _processed, queryResults, result) => {
const out = queryResults as QueryResults<'resolve-value'>['resolve-value'];
result.push(`Query: ${bold('resolve-value', formatter)} (${printAsMs(out['.meta'].timing, 0)})`);
for(const [fingerprint, obj] of Object.entries(out.results)) {
const { criteria } = JSON.parse(fingerprint) as ResolveValueQuery;
result.push(` ╰ Values for {${criteria.join(', ')}}`);
result.push(` ╰ ${obj.values.map(v => rValueToAscii(v as string | RNumberValue | RStringValue)).join(', ')}`);
}
return true;
},
schema: Joi.object({
type: Joi.string().valid('resolve-value').required().description('The type of the query.'),
criteria: Joi.array().items(Joi.string()).min(0).required().description('The slicing criteria to use.'),
EagleoutIce marked this conversation as resolved.
Show resolved Hide resolved
}).description('Resolve Value query used to get definitions of an identifier')
} as const satisfies SupportedQuery<'resolve-value'>;
8 changes: 6 additions & 2 deletions src/queries/query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ import type {
import {
HappensBeforeQueryDefinition
} from './catalog/happens-before-query/happens-before-query-format';
import type { ResolveValueQuery } from './catalog/resolve-value-query/resolve-value-query-format';
import { ResolveValueQueryDefinition } from './catalog/resolve-value-query/resolve-value-query-format';

export type Query = CallContextQuery
| ConfigQuery
Expand All @@ -47,7 +49,8 @@ export type Query = CallContextQuery
| LineageQuery
| DependenciesQuery
| LocationMapQuery
| HappensBeforeQuery;
| HappensBeforeQuery
| ResolveValueQuery;

export type QueryArgumentsWithType<QueryType extends BaseQueryFormat['type']> = Query & { type: QueryType };

Expand Down Expand Up @@ -76,7 +79,8 @@ export const SupportedQueries = {
'dependencies': DependenciesQueryDefinition,
'location-map': LocationMapQueryDefinition,
'search': SearchQueryDefinition,
'happens-before': HappensBeforeQueryDefinition
'happens-before': HappensBeforeQueryDefinition,
'resolve-value': ResolveValueQueryDefinition
} as const satisfies SupportedQueries;

export type SupportedQueryTypes = keyof typeof SupportedQueries;
Expand Down
41 changes: 41 additions & 0 deletions test/functionality/dataflow/query/resolve-value-query.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import { assertQuery } from '../../_helper/query';
import { label } from '../../_helper/label';
import { withShell } from '../../_helper/shell';
import { assert, describe } from 'vitest';
import type { ResolveValueQuery, ResolveValueQueryResult } from '../../../../src/queries/catalog/resolve-value-query/resolve-value-query-format';
import { fingerPrintOfQuery } from '../../../../src/queries/catalog/resolve-value-query/resolve-value-query-executor';
import { resolveToValues } from '../../../../src/dataflow/environments/resolve-by-name';
import { slicingCriterionToId } from '../../../../src/slicing/criterion/parse';
import { recoverName } from '../../../../src/r-bridge/lang-4.x/ast/model/processing/node-id';

describe.sequential('Resolve Value Query', withShell(shell => {
function testQuery(name: string, code: string, queries: readonly ResolveValueQuery[]) {
assertQuery(label(name), shell, code, queries, ({ dataflow }) => {
const results: ResolveValueQueryResult['results'] = {};

const idMap = dataflow.graph.idMap;
assert(idMap !== undefined);

for(const query of queries) {
const key = fingerPrintOfQuery(query);
const identifiers = query.criteria
.map(criteria => slicingCriterionToId(criteria, idMap))
.map(id => recoverName(id, idMap));

const values = identifiers
.flatMap(id => resolveToValues(id, dataflow.environment, dataflow.graph));

results[key] = {
values: [... new Set(values)]
};
}

return {
'resolve-value': { results }
};
});
gigalasr marked this conversation as resolved.
Show resolved Hide resolved
}

testQuery('Single dataflow', 'x <- 1', [{ type: 'resolve-value', criteria: ['1@x'] }]);
testQuery('Multiple Queries', 'x <- 1', [{ type: 'resolve-value', criteria: ['1@x'] }, { type: 'resolve-value', criteria: ['1@x'] }, { type: 'resolve-value', criteria: ['1@x'] }]);
}));
Loading