Improve Slicing of Functions Which Read From Their Closure #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EagleoutIce
deleted the
1218-too-brought-slice-when-the-return-value-of-a-function-is-a-recursive-call
branch
|
This pull request is included in v2.1.9 (see Release v2.1.9 (Improved Closure Slicing, DFG docs, and Support for the Car Package)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And minor improvements to the documentation generation mechanism (removed duplicated mermaid code and added highlighting for R within the code documentation).
The main fix relates to adding a relink for the global expression list which re-iterates the function calls and in turn saves on the additional mapping performed in the slicing