Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Abstract Domains iii]: Resolve constant aliases #1201

Merged
merged 27 commits into from
Dec 23, 2024
Merged

[Abstract Domains iii]: Resolve constant aliases #1201

merged 27 commits into from
Dec 23, 2024

Conversation

gigalasr
Copy link
Collaborator

@gigalasr gigalasr commented Dec 5, 2024

No description provided.

@gigalasr gigalasr linked an issue Dec 5, 2024 that may be closed by this pull request
[Abstract Domains, III] Resolve Constant Aliases #1106
Closed
@gigalasr gigalasr changed the title 1106 abstract domains iii resolve constant aliases [Abstract Domains iii]: Resolve constant aliases Dec 5, 2024
EagleoutIce
EagleoutIce approved these changes Dec 11, 2024
View reviewed changes
src/dataflow/environments/resolve-by-name.ts Show resolved Hide resolved
src/dataflow/environments/resolve-by-name.ts Outdated Show resolved Hide resolved
src/dataflow/environments/resolve-by-name.ts Outdated Show resolved Hide resolved
@EagleoutIce
Copy link
Member

Besides the two cases i sent to you, you can use call-context-query.test.ts#Aliases replacing the print call (or whatever it is we search for in the test) by a value such as 3 or "hey".

@EagleoutIce
Copy link
Member

Maybe consider doing #1135 afterward c:

@EagleoutIce EagleoutIce marked this pull request as ready for review December 23, 2024 06:27
@EagleoutIce EagleoutIce mentioned this pull request Dec 23, 2024
Open
@EagleoutIce
Copy link
Member

Increased testing is deferred to #1222

@EagleoutIce EagleoutIce merged commit 58121ad into main Dec 23, 2024
17 checks passed
@EagleoutIce EagleoutIce deleted the 1106-abstract-domains-iii-resolve-constant-aliases branch December 23, 2024 15:27
@EagleoutIce
Copy link
Member

This pull request is included in v2.1.10 (see Release v2.1.10 (First support for pointer analysis (named list arguments with $))).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EagleoutIce EagleoutIce EagleoutIce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Abstract Domains, III] Resolve Constant Aliases
2 participants
@gigalasr @EagleoutIce