Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for named list arguments #1151

Merged
merged 32 commits into from
Jan 5, 2025
Merged

Added support for named list arguments #1151

merged 32 commits into from
Jan 5, 2025

Conversation

Slartibartfass2
Copy link
Collaborator

Closes #1139

Added

  • named arguments of lists are added to data flow graph
  • when a named argument is accessed, a reads edge to the specific list element is added

@Slartibartfass2 Slartibartfass2 self-assigned this Nov 15, 2024
@Slartibartfass2 Slartibartfass2 linked an issue Nov 15, 2024 that may be closed by this pull request
Add support for named list arguments (field-sensitive pointer analysis) #1139
Closed
@Slartibartfass2 Slartibartfass2 force-pushed the 1139-add-support-for-named-list-arguments-field-sensitive-pointer-analysis branch 7 times, most recently from 8a2d646 to 3e1384d Compare November 21, 2024 09:41
@Slartibartfass2 Slartibartfass2 force-pushed the 1139-add-support-for-named-list-arguments-field-sensitive-pointer-analysis branch 2 times, most recently from f5c30b5 to 8417576 Compare November 27, 2024 11:03
@Slartibartfass2 Slartibartfass2 force-pushed the 1139-add-support-for-named-list-arguments-field-sensitive-pointer-analysis branch 3 times, most recently from 3bc497c to 25d8b0d Compare December 4, 2024 17:05
@Slartibartfass2 Slartibartfass2 force-pushed the 1139-add-support-for-named-list-arguments-field-sensitive-pointer-analysis branch 3 times, most recently from 0216e11 to c578925 Compare December 13, 2024 16:08
@Slartibartfass2
feat: added processor for list function call
b6ef666
@Slartibartfass2
feat: named arguments are defined as indices for target of list assig…
6bdbddb 
…nment
@Slartibartfass2
feat: reads edge is added to list element when accessing via '$'
9a00dc1
@Slartibartfass2
test(list-access): added slicing tests
41a1670
@Slartibartfass2
test(list-access): added dataflow tests
35ece1f
@Slartibartfass2
test-fix: fix list-access test suites
99c4f7f
@Slartibartfass2
feat(list-access): all parameter indices are concatenated
1305437
@Slartibartfass2
feat(list-access): pass indices of replacement to markAsAssignment
9dbdb32
@Slartibartfass2
feat(list-access): all existing definitions are read by access
c3a4cb0
@Slartibartfass2
feat-fix(list-access): correct nodeId is used for ContainerIndex
79b2be0
@Slartibartfass2
feat(list-access): merge definition properties with same name
b844291 
This way only the correct definition is stored. Any overwritten definition isn't stored anymore. Currently, this only works for definition that happen in each branch.
@Slartibartfass2
feat(list-access): add isSingleIndex property to container indices
4941912
@Slartibartfass2
test(list-access): extended slicing tests
e2f1c82
@Slartibartfass2
feat(list-access): replacement function are not marked as maybe anymore
199221d 
The merge indices logic was merged to a separate method.
When there are indices defined, then the function is not marked as maybe.
This enables overwriting the previous indices.
@Slartibartfass2
feat(list-access): add whole list reference only to list call
1bf8e14 
Before, an access to a list object would reference the whole object, now that's only
when the list function is called. Single assignments are referenced directly by their
access operator. This allows us to skip not relevant list accesses.
@Slartibartfass2
test-fix(list-access): list call is always in slice
b32a72d 
To ensure a executable slice, the list call has to be always in the slice.
@Slartibartfass2
feat(list-access): overwrite definition of indices if list is redefined
059b4e5 
When a list is redefined the former definiton is replaced, therefore storing the indices would cause
keeping the previous definition in the slice.
@Slartibartfass2
refactor(access): extracted number and index based access to methods
d6e468e
@Slartibartfass2
test(list-access): add tests for nested list access
24ab716 
Nested list access comes with new complications. For each list in the root index, the names
must be resolved recursively, to reference the correct index.
@Slartibartfass2
feat(nested-list): add subindices to index if index is another list
14e2fa4 
This enables nested defintion/access/assignment.
@Slartibartfass2
feat(nested-list): add reads edges to accessed indices and their indices
870c5eb 
This is done recursively to include all indices that had an impact on the result.
@Slartibartfass2
feat(nested-list): recursively resolve nested access
71f7d2b
@Slartibartfass2 Slartibartfass2 force-pushed the 1139-add-support-for-named-list-arguments-field-sensitive-pointer-analysis branch from c578925 to 71f7d2b Compare December 30, 2024 11:38
@Slartibartfass2 Slartibartfass2 marked this pull request as ready for review January 2, 2025 12:57
@EagleoutIce EagleoutIce merged commit 4b73726 into main Jan 5, 2025
17 checks passed
@EagleoutIce EagleoutIce deleted the 1139-add-support-for-named-list-arguments-field-sensitive-pointer-analysis branch January 5, 2025 08:18
@EagleoutIce
Copy link
Member

This pull request is included in v2.1.10 (see Release v2.1.10 (First support for pointer analysis (named list arguments with $))).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EagleoutIce EagleoutIce Awaiting requested review from EagleoutIce

Assignees

@Slartibartfass2 Slartibartfass2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for named list arguments (field-sensitive pointer analysis)
2 participants
@Slartibartfass2 @EagleoutIce