Skip to content

Hello from Testcontainers!#3

Description

@mdelapenya

Hi! Manu from Testcontainers Go here 馃憢

I discovered this project today, seems pretty cool! So I decided to come and say hello and offer our assistance (here in Go or in the rest of language implementations).

I.e., for Go, it would be wonderful if the Floci module follows the convention (sadly there is no interface/API... yet?) to enforce a Run entrypoint function for the module, like the modules existing in the module catalog. So instead of

floci.NewFlociContainer().Start(ctx)

users would do

options := // use the existing options to model the container request
floci.Run(ctx, ...options)

Also, in https://github.com/floci-io/testcontainers-floci-go/blob/main/floci.go#L520, if possible, move to the Run function would be of interest too.

Just a couple of suggestions for consistency with the other modules, so the users in the ecosystem get familiar with the existing APIs. But please feel free to keep your own API if you consider it right, I'm just here a bystander :)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions