Uiupdates - #212
Conversation
|
| Filename | Overview |
|---|---|
| packages/frontend/index.html | Replaces Sora and Space Mono font loading with Inter and expanded JetBrains Mono weights, leaving inconsistent Space Mono-first declarations elsewhere. |
| packages/frontend/src/index.css | Applies a broad visual theme refresh; the new primary-button color combination has insufficient normal-text contrast. |
| example.txt | Adds an empty file with no functional effect. |
Reviews (1): Last reviewed commit: "ui update" | Re-trigger Greptile
| .button.primary { | ||
| background: #3949ab; | ||
| border-color: #3949ab; | ||
| color: white; | ||
| background: var(--accent); | ||
| border-color: var(--accent); | ||
| color: #ffffff; | ||
| font-weight: 600; | ||
| box-shadow: 0 1px 2px rgba(0, 0, 0, 0.15); | ||
| } | ||
|
|
||
| .button.primary:hover { | ||
| background: #5c6bc0; | ||
| border-color: #5c6bc0; | ||
| background: var(--accent-hover); | ||
| border-color: var(--accent-hover); | ||
| color: #ffffff; | ||
| box-shadow: 0 2px 4px rgba(0, 0, 0, 0.2); |
There was a problem hiding this comment.
Primary buttons now render 11–12px white labels on #d97757, changing to #c46545 on hover. These combinations provide approximately 3.1:1 and 4.0:1 contrast, below the 4.5:1 threshold for normal text, so primary actions may be difficult to read. Please adjust the foreground or background colors to provide sufficient contrast in both states.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <link rel="icon" href="/src/assets/floci-black.svg" /> | ||
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Sora:wght@300;400;500;600;700;800&family=Space+Mono:wght@400;700&family=JetBrains+Mono:wght@400;500&display=swap" | ||
| href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&family=JetBrains+Mono:wght@400;500;600&display=swap" |
There was a problem hiding this comment.
Inconsistent Monospace Rendering
The updated font request stops loading Space Mono, but several CSS declarations still prioritize it over JetBrains Mono. Clients with Space Mono installed locally will use it, while other clients will fall back to JetBrains Mono, producing inconsistent code, log, and metadata typography. Please update those declarations or continue loading Space Mono.
Summary
Type of change
fix:)feat:)feat!:orfix!:)Area
packages/frontend)packages/api)Verification
Checklist
pnpm lint,pnpm type-check,pnpm test, andpnpm buildpass locallybun testinpackages/api)