Skip to content

fix(firebaseauth): send CORS headers on the emulator endpoints and always vary on Origin #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianpardal wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(firebaseauth): send CORS headers on the emulator endpoints and always vary on Origin #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e28be32
fix(firebaseauth): send CORS headers on the emulator management endpo…
ianpardal Sep 7, 2026
b6533c4
fix(firebaseauth): vary on Origin even when the request carries none
ianpardal Sep 7, 2026
69cd262
style(firebaseauth): drop the Vary comment from the CORS route filter
ianpardal Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/io/floci/gcp/services/firebaseauth/FirebaseAuthCorsRouteFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@
@ApplicationScoped
public class FirebaseAuthCorsRouteFilter {

// FirebaseAuthController (sign-in/sign-up) and SecureTokenController (token refresh).
// FirebaseAuthController (sign-in/sign-up), SecureTokenController (token refresh) and
// FirebaseAuthEmulatorController, which the Emulator UI calls from the browser.
private static final String[] PATH_PREFIXES = {
"/identitytoolkit.googleapis.com/*",
"/securetoken.googleapis.com/*",
"/emulator/v1/*",
};

// Matches expressjs/cors' defaults, which is what firebase-tools' Auth Emulator uses.
Expand All @@ -35,6 +37,8 @@ void init() {
}

private void handle(RoutingContext ctx) {
ctx.response().putHeader("Vary", "Origin");

String origin = ctx.request().getHeader("Origin");
if (origin == null) {
ctx.next();
Expand All @@ -43,7 +47,6 @@ private void handle(RoutingContext ctx) {
ctx.response().putHeader("Access-Control-Allow-Origin", origin);

if (!"OPTIONS".equalsIgnoreCase(ctx.request().method().name())) {
ctx.response().putHeader("Vary", "Origin");
ctx.next();
return;
}
Expand Down
32 changes: 30 additions & 2 deletions src/test/java/io/floci/gcp/services/firebaseauth/FirebaseAuthCorsRestIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
class FirebaseAuthCorsRestIntegrationTest {

private static final String CLIENT = "/identitytoolkit.googleapis.com/v1/accounts";
private static final String EMULATOR = "/emulator/v1";
private static final String ORIGIN = "http://127.0.0.1:59301";

@Test
Expand Down Expand Up @@ -61,7 +62,33 @@ void preflightForSecureTokenRefreshAdvertisesTheRequestedOrigin() {
}

@Test
void requestWithNoOriginGetsNoCorsHeaders() {
void preflightForEmulatorDeleteAllAccountsAdvertisesTheRequestedOrigin() {
given()
.header("Origin", ORIGIN)
.header("Access-Control-Request-Method", "DELETE")
.header("Access-Control-Request-Headers", "Content-Type")
.when().options(EMULATOR + "/projects/cors-emulator-probe/accounts")
.then()
.statusCode(204)
.header("Access-Control-Allow-Origin", equalTo(ORIGIN))
.header("Access-Control-Allow-Methods", equalTo("GET,HEAD,PUT,PATCH,POST,DELETE"))
.header("Access-Control-Allow-Headers", equalTo("Content-Type"))
.header("Vary", equalTo("Origin, Access-Control-Request-Headers"));
}

@Test
void actualEmulatorDeleteAllAccountsResponseAdvertisesTheRequestedOrigin() {
given()
.header("Origin", ORIGIN)
.when().delete(EMULATOR + "/projects/cors-emulator-probe/accounts")
.then()
.statusCode(200)
.header("Access-Control-Allow-Origin", equalTo(ORIGIN))
.header("Vary", equalTo("Origin"));
}

@Test
void requestWithNoOriginStillVariesOnOrigin() {
given()
.urlEncodingEnabled(false)
.contentType("application/json")
Expand All @@ -72,6 +99,7 @@ void requestWithNoOriginGetsNoCorsHeaders() {
.when().post(CLIENT + ":signUp")
.then()
.statusCode(200)
.header("Access-Control-Allow-Origin", nullValue());
.header("Access-Control-Allow-Origin", nullValue())
.header("Vary", equalTo("Origin"));
}
}