You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Queries such as IS_DEFINED(c.rsvpVersionsByUserId[""]) miss references stored only in an RSVP version map because quoted bracket members were unresolved.
Resolve quoted bracket members alongside dotted members, preserving dots, spaces, empty names, and escaped characters. Share property parsing with composite-index validation and preserve correlated subquery aliases of any length. Carry escaped quotes safely through whitespace normalization, parameter substitution, clause scanning, and projection. Bracket projections use decoded property names, and parameter values retain literal backslashes.
Validation:
Original four property tests and both initial review regressions failed before their respective fixes.
Three additional review regressions failed first: escaped keys in complete SQL queries, bracket projection names, and trailing backslashes in parameters.
All 142 Cosmos Java tests pass. Extended .NET Cosmos SDK test passes against the packaged JVM server, covering the erasure shape plus escaped and dotted property projections.
Full Java suite: 1,074 tests, one failure in unchanged SqlProvisioningServiceTest.boundsRetainedTerminalOperations, 14 existing skips. Retention sorts ConcurrentHashMap values only by endTime, so equal timestamps make the expected first eviction unspecified. The preceding full run passed with 1,073 tests. SQL files are unchanged.
Full diff reviewed and simplified; git diff --check passes.
This PR extends the embedded Cosmos SQL evaluator to resolve quoted bracket property members consistently across predicates, projections, correlated subqueries, and composite-index validation.
Parses dotted and quoted bracket members through a shared property-path implementation.
Preserves escaped characters and literal backslashes throughout SQL normalization, parameter substitution, and clause scanning.
Uses decoded bracket member names for projected output.
Adds focused Java regressions and an end-to-end .NET Cosmos SDK compatibility test.
Confidence Score: 5/5
The PR appears safe to merge; the previous query-resolution findings are fixed and no new actionable regressions remain.
The current implementation defines and uses the shared helper successfully, recognizes correlated aliases without the former length limit, preserves quoted dots during index normalization, and safely carries escaped bracket keys and parameter backslashes through parsing and projection. All previous findings are resolved in the current code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries such as IS_DEFINED(c.rsvpVersionsByUserId[""]) miss references stored only in an RSVP version map because quoted bracket members were unresolved.
Resolve quoted bracket members alongside dotted members, preserving dots, spaces, empty names, and escaped characters. Share property parsing with composite-index validation and preserve correlated subquery aliases of any length. Carry escaped quotes safely through whitespace normalization, parameter substitution, clause scanning, and projection. Bracket projections use decoded property names, and parameter values retain literal backslashes.
Validation: