Fmpz mod mat rand and randfull functions #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor naming thing: I prefer |
vneiger
reviewed
Oct 27, 2025
vneiger
reviewed
Oct 27, 2025
vneiger
reviewed
Oct 27, 2025
vneiger
reviewed
Oct 27, 2025
vneiger
reviewed
Oct 27, 2025
vneiger
reviewed
Oct 27, 2025
vneiger
reviewed
Oct 27, 2025
vneiger
reviewed
Oct 27, 2025
vneiger
reviewed
Oct 27, 2025
vneiger
changed the title
vneiger
reviewed
Oct 27, 2025
Co-authored-by: Vincent Neiger <[email protected]>
dlesnoff
force-pushed
the
fmpz_mod_mat_randfull
branch
from
fe74c71 to
2ff76f1
Compare
vneiger
reviewed
Oct 28, 2025
vneiger
reviewed
Oct 28, 2025
Co-authored-by: Vincent Neiger <[email protected]>
Co-authored-by: vneiger <[email protected]>
|
The last changes look good to me. When CI completes, ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to improve in this pull request the random generation functions for matrices mod n.
Partially answers #2424 #715
I added documentation for the
fmpz_randtestfunction. Only the unsigned variant was documented.I had to update
fmpz_mat_randtestto generate sparse matrices with increased probability, so thatfmpz_mod_mat_randtestalso generates sparse matrices with increased probability.I made sure that the new
fmpz_mod_mat_randfulldoes not generate zero to check for overflows.Most importantly, we have now
fmpz_mod_vec_randunifandfmpz_mod_mat_randunifwhich generates fully dense coefficients uniformly with potential zero coefficients.I will perform polynomial in another PR.