Skip to content

Test: this pull request should not be managed by the bot #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmetzger
Copy link

@rmetzger rmetzger commented Feb 1, 2019

No description provided.

@rmetzger
Copy link
Author

rmetzger commented Feb 1, 2019

Because the min pr id is 15, this PR is 8.

@rmetzger
Copy link
Author

rmetzger commented Feb 4, 2019

Testing collapsable sections:

Bot commands The Flink bot supports the following commands:
  • @flinkbot approve description (similarly, it also supports the `` keywords)
  • @flinkbot approve all

@flinkbot
Copy link
Owner

flinkbot commented Feb 4, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❌ 1. The [description] looks good.
  • ❌ 2. There is [consensus] that the contribution should go into to Flink.
  • ✅ 3. [Does not need specific [attention] | Needs specific attention for X | Has attention for X by Y]
  • ❌ 4. The [architecture] is sound.
  • ❌ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

@rmetzger
Copy link
Author

rmetzger commented Feb 4, 2019

  • ✅1. The [contribution] is well-described.
  • ❌2. There is [consensus] that the contribution should go into to Flink.
  • ❌3. [Does not need specific [attention] | Needs specific attention for X | Has attention for X by Y]
  • ❌4. The [architecture] is sound.
  • ✅ 5. Overall code [quality] is good.

@aljoscha
Copy link

aljoscha commented Feb 4, 2019

@flinkbot attention @rmetzger

@rmetzger
Copy link
Author

rmetzger commented Feb 4, 2019

the bot in this repo is currently switched off :)

@rmetzger
Copy link
Author

rmetzger commented Feb 4, 2019

@flinkbot update comments please :)

@rmetzger
Copy link
Author

rmetzger commented Feb 4, 2019

@flinkbot re-render. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants