EDM-2452: Clean up removed env vars from ui quadlet

[DakCrowder]

Removes the INTERNAL_AUTH_URL and AUTH_CLIENT_ID deprecated env vars from the UI quadlet

UI pr that removes these variables for reference: flightctl/flightctl-ui#378

Summary by CodeRabbit

• Chores
  • Removed authentication type–based configuration generation from deployment templates.
  • No alternative per-type auth configuration was added in this change.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

A conditional block generating AUTH_CLIENT_ID and INTERNAL_AUTH_URL environment variables based on authentication type (aap, oidc, or default) was removed from the env.template configuration file without replacement.

Changes

Cohort / File(s)	Summary
Auth configuration template removal deploy/podman/flightctl-ui/flightctl-ui-config/env.template	Removed conditional block that generated AUTH_CLIENT_ID and INTERNAL_AUTH_URL based on .global.auth.type (aap, oidc, or default branches), including nested fallback logic for pamOidcIssuer and oidc.issuer. No replacement logic introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify that removal of AUTH_CLIENT_ID and INTERNAL_AUTH_URL generation does not break authentication workflows.
• Confirm authentication type-specific configuration is no longer required or has been relocated.
• Check for dependent configs/services or deployment scripts that reference these environment variables.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: removing deprecated environment variables from the UI quadlet config template, which aligns with the removed AUTH_CLIENT_ID and INTERNAL_AUTH_URL logic in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 523af7e and 4536885.

📒 Files selected for processing (1)

• deploy/podman/flightctl-ui/flightctl-ui-config/env.template (0 hunks)

💤 Files with no reviewable changes (1)

• deploy/podman/flightctl-ui/flightctl-ui-config/env.template

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)

• GitHub Check: rpm-build:epel-10-aarch64
• GitHub Check: rpm-build:fedora-43-x86_64
• GitHub Check: rpm-build:epel-9-aarch64
• GitHub Check: rpm-build:epel-10-aarch64
• GitHub Check: rpm-build:epel-9-aarch64
• GitHub Check: rpm-build:fedora-43-x86_64
• GitHub Check: Build Binaries (windows-amd64)
• GitHub Check: Build Binaries (darwin-arm64)
• GitHub Check: Build Binaries (darwin-amd64)
• GitHub Check: Build Binaries (linux-arm64)
• GitHub Check: Build Binaries (linux-amd64)
• GitHub Check: rpm-build:epel-10-aarch64
• GitHub Check: rpm-build:epel-9-aarch64
• GitHub Check: rpm-build:fedora-43-x86_64
• GitHub Check: e2e-tests (3)
• GitHub Check: e2e-tests (4)
• GitHub Check: e2e-tests (2)
• GitHub Check: e2e-tests (1)
• GitHub Check: unit-tests
• GitHub Check: integration-tests
• GitHub Check: lint
• GitHub Check: smoke

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}