Skip to content

[Release-1.0] EDM-2813: Do not attempt to refresh in a loop #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
celdrake merged 1 commit into from
Dec 16, 2025
Merged

[Release-1.0] EDM-2813: Do not attempt to refresh in a loop #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions apps/standalone/src/app/context/AuthContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,19 +189,26 @@ export const useAuthContext = () => {
credentials: 'include',
method: 'GET',
});

if (!resp.ok) {
// We only attempt refreshing once. If it fails, the user will be soon logged out
localStorage.removeItem(EXPIRATION);
return;
}

const expiration = (await resp.json()) as { expiresIn: number };
const now = nowInSeconds();
if (expiration.expiresIn) {
const now = nowInSeconds();
localStorage.setItem(EXPIRATION, `${now + expiration.expiresIn}`);
lastRefresh = now;
// Schedule next refresh based on expiration
scheduleRefresh();
} else {
localStorage.removeItem(EXPIRATION);
}
lastRefresh = now;
} catch (err) {
// eslint-disable-next-line
console.log('failed to refresh token:', err);
} finally {
scheduleRefresh();
// By deleting the expiration, the next API request will get 401 and redirect to login
localStorage.removeItem(EXPIRATION);
}
};

Expand Down