Skip to content

Do now show login error before flow starts #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
celdrake merged 1 commit into from
Nov 27, 2025
Merged

Do now show login error before flow starts #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions apps/standalone/src/app/context/AuthContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,14 @@ export const useAuthContext = () => {
});

if (resp.status === 401) {
// Extract error message from response if available
const isOnAuthPage = ['/login', '/callback'].includes(window.location.pathname);
if (!isOnAuthPage) {
// The user is not authenticated - start the login process, and do not show any authentication errors yet
setLoading(false);
redirectToLogin();
return;
}

let errorMessage = t('Authentication failed. Please try logging in again.');
try {
const contentType = resp.headers.get('content-type');
Expand All @@ -119,10 +126,6 @@ export const useAuthContext = () => {
// If parsing fails, use default error message
}
setError(errorMessage);
// Don't redirect if we're already on the login or login callback pages
if (!['/login', '/callback'].includes(window.location.pathname)) {
redirectToLogin();
}
setLoading(false);
return;
}
Expand Down